Re: [PATCH net-next v3 3/6] net: phy: air_phy_lib: Factorize BuckPBus register accessors

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing explicit `#include <linux/wordpart.h>` in `drivers/net/phy/air_phy_lib.c`.
--

commit a5ca176575453118a1f5a166311004f5cc86600c
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

net: phy: air_phy_lib: Factorize BuckPBus register accessors

This commit moves the BuckPBus register accessors and definitions from the
air_en8811h driver into the shared air_phy_lib code to allow reuse by the
upcoming Airoha AN8801R PHY driver.

[ ... ]

> diff --git a/drivers/net/phy/air_phy_lib.c b/drivers/net/phy/air_phy_lib.c
> index 8ef5af4becf03..687c59197b163 100644
> --- a/drivers/net/phy/air_phy_lib.c
> +++ b/drivers/net/phy/air_phy_lib.c
> @@ -15,6 +15,186 @@
>  
>  #define AIR_EXT_PAGE_ACCESS		0x1f
>  
> +static int __air_buckpbus_reg_read(struct phy_device *phydev,
> +				   u32 pbus_address, u32 *pbus_data)
> +{
> +	int pbus_data_low, pbus_data_high;
> +	int ret;
> +
> +	ret = __phy_write(phydev, AIR_BPBUS_MODE, AIR_BPBUS_MODE_ADDR_FIXED);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = __phy_write(phydev, AIR_BPBUS_RD_ADDR_HIGH,
> +			  upper_16_bits(pbus_address));

This isn't a bug, but should linux/wordpart.h be explicitly included in
this file?

These functions rely on upper_16_bits() and lower_16_bits(), which appear
to be pulled in implicitly through other headers.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-add-airoha-an8801-support-v3-0-1edb34e363ae@collabora.com?part=3