From: <liu.qingtao2@zte.com.cn>
To: <gregkh@linuxfoundation.org>
Cc: <krzk@kernel.org>, <jirislaby@kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <marex@nabladev.com>,
<pjw@kernel.org>, <palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<alex@ghiti.fr>, <rdunlap@infradead.org>,
<geert+renesas@glider.be>, <quic_zongjian@quicinc.com>,
<arturs.artamonovs@analog.com>, <robert.marko@sartura.hr>,
<hvilleneuve@dimonoff.com>, <thierry.bultel.yh@bp.renesas.com>,
<julianbraha@gmail.com>, <flavra@baylibre.com>,
<prabhakar.mahadev-lad.rj@bp.renesas.com>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<liu.wenhong35@zte.com.cn>, <dai.hualiang@zte.com.cn>,
<deng.weixian@zte.com.cn>, <jia.yunxiang@zte.com.cn>,
<bai.lu5@zte.com.cn>, <yang.susheng@zte.com.cn>,
<shen.lin1@zte.com.cn>, <zuo.jiang@zte.com.cn>,
<hu.shengming@zte.com.cn>, <gao.rui@zte.com.cn>,
<tan.hu@zte.com.cn>, <liu.qingtao2@zte.com.cn>
Subject: Re: [PATCH v1 2/2] LRW UART: serial: add driver for the LRW UART
Date: Wed, 13 May 2026 16:44:27 +0800 (CST) [thread overview]
Message-ID: <202605130852.64D8qdE5044241@mse-fl2.zte.com.cn> (raw)
> On Fri, Feb 13, 2026 at 05:33:34PM +0800, LiuQingtao wrote:
> > From: Wenhong Liu <liu.wenhong35@zte.com.cn>
> >
> > This commit introduces a serial driver for the LRW UART controller
> >
> > Key features implemented:
> > - Support for FIFO mode (16-byte depth)
> > - Baud rate configuration
> > - Standard asynchronous communication formats:
> > * Data bits: 5, 6, 7, 8, 9 bits
> > * Parity: odd, even, fixed, none
> > * Stop bits: 1 or 2 bits
> > - Hardware flow control (RTS/CTS)
> > - Multiple interrupt reporting mechanisms
> >
> > Signed-off-by: Wenhong Liu <liu.wenhong35@zte.com.cn>
> > Signed-off-by: Qingtao Liu <liu.qingtao2@zte.com.cn>
> > ---
> > MAINTAINERS | 3 +
> > drivers/tty/serial/Kconfig | 33 +
> > drivers/tty/serial/Makefile | 1 +
> > drivers/tty/serial/lrw_uart.c | 2822 ++++++++++++++++++++++++++++++
>
> This really is a totally new uart? No relation to any existing devices
> at all? Why would that be created?
>
> Anyway, this doesn't seem to build properly, how was it tested?
Yes, it`s a new uart for lrx SoC. The lrx SoC with its related docs will be released soon.
The uart TX & RX test environment:
1.Kernel: linux-next, commit 4cd074ae20bbcc293bbbce9163abe99d68ae6ae0(Tue May 5 14:57:23 2026 +0200),
with CONFIG_SERIAL_LRX_UART and SERIAL_LRX_UART_CONSOLE selected.
2.GCC: 14.1.0.
3.SoC: lrx SoC.
> > --- a/include/uapi/linux/serial_core.h
> > +++ b/include/uapi/linux/serial_core.h
> > @@ -231,6 +231,9 @@
> > /* Sunplus UART */
> > #define PORT_SUNPLUS 123
> >
> > +/* LRW UART */
> > +#define PORT_LRW 124
>
> Why is this id needed?
>
> thanks,
>
> greg k-h
Thanks for notice. This id is not needed actually.
According to https://lore.kernel.org/all/20231008001804.889727-1-jcmvbkbc@gmail.com/, the specific type
of the port is not important to the userspace.
next reply other threads:[~2026-05-13 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 8:44 liu.qingtao2 [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-13 8:43 [PATCH v1 2/2] LRW UART: serial: add driver for the LRW UART liu.qingtao2
2026-05-13 18:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202605130852.64D8qdE5044241@mse-fl2.zte.com.cn \
--to=liu.qingtao2@zte.com.cn \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=arturs.artamonovs@analog.com \
--cc=bai.lu5@zte.com.cn \
--cc=conor+dt@kernel.org \
--cc=dai.hualiang@zte.com.cn \
--cc=deng.weixian@zte.com.cn \
--cc=devicetree@vger.kernel.org \
--cc=flavra@baylibre.com \
--cc=gao.rui@zte.com.cn \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hu.shengming@zte.com.cn \
--cc=hvilleneuve@dimonoff.com \
--cc=jia.yunxiang@zte.com.cn \
--cc=jirislaby@kernel.org \
--cc=julianbraha@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=liu.wenhong35@zte.com.cn \
--cc=marex@nabladev.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_zongjian@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=shen.lin1@zte.com.cn \
--cc=tan.hu@zte.com.cn \
--cc=thierry.bultel.yh@bp.renesas.com \
--cc=yang.susheng@zte.com.cn \
--cc=zuo.jiang@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox