From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [160.30.148.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAE2E3DD868; Wed, 13 May 2026 08:53:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=160.30.148.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778662390; cv=none; b=oZGIWH2GXvsRoMWAtboT0AvNhOj6uLXbACzVPD/qFwC0WlJZJMOt5ozLSVLkX7RKNJSov3uuGLxW5Tcz5u5+tT6eGoqyxczp+OrO53c4TF7FMT7X8pHoSkaW+BcNpw19muhnfEij7a6HQnbkIfTgjLuOGscS9Omv7jddea+Aopw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778662390; c=relaxed/simple; bh=whMHt/Mh/Tx38JTL+Vhv1TzvaNrNNWRqYHuR4N/i17k=; h=Message-Id:References:Date:Mime-Version:From:To:Cc:Subject: Content-Type; b=STrI0cwhR2mYrJ/50e4zaUB3zNXXAhI2vXHU+CHgWnxgy6rqhjAlDSG5ABit3TqL1FhREKB1W8B4gMlQ5g7qkk1wHj4bDlDgcm2v7E1hEOMJF+q0YWBK2NoXFSLpEgJK5jkC2Z6NaeRax5OeqjXcwLfTJlMESKzONjQ8pZjpkco= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn; spf=pass smtp.mailfrom=zte.com.cn; arc=none smtp.client-ip=160.30.148.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zte.com.cn Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4gFnKv3DD1z8Xs79; Wed, 13 May 2026 16:53:07 +0800 (CST) Received: (from root@localhost) by mse-fl2.zte.com.cn id 64D8r4bc045011; Wed, 13 May 2026 16:53:04 +0800 (+08) (envelope-from liu.qingtao2@zte.com.cn) Message-Id: <202605130853.64D8r4bc045011@mse-fl2.zte.com.cn> Received: from njb2app07.zte.com.cn ([10.55.22.95]) by mse-fl1.zte.com.cn with SMTP id 64D8hURw067028; Wed, 13 May 2026 16:43:30 +0800 (+08) (envelope-from liu.qingtao2@zte.com.cn) Received: from mapi (njy2app03[null]) by mapi (Zmail) with MAPI id mid204; Wed, 13 May 2026 16:43:32 +0800 (CST) X-Zmail-TransId: 2afb6a0439b49a7-f3b0c X-Mailer: Zmail v1.0 References: 20260213093334.9217-1-qtliu@mail.ustc.edu.cn,20260213093334.9217-2-qtliu@mail.ustc.edu.cn,6ba2a916-739c-4c4a-92a6-951707aaa212@kernel.org,20260428212336808bXjbShOLllb6pYKXa129p@zte.com.cn,20260428231045453wLt2Gv66dV7Noa4l7ATlD@zte.com.cn,20260430171839401JJ1qBY9RPFfFISK8d2gVZ@zte.com.cn Date: Wed, 13 May 2026 16:43:32 +0800 (CST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 From: To: Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: =?UTF-8?B?UmU6IFtQQVRDSCB2MSAxLzJdIExSVyBVQVJUOiBkdC1iaW5kaW5nczogQWRkIGJpbmRpbmcgZm9yIExSVyBVQVJU?= Content-Type: text/plain; charset="UTF-8" X-MAIL:mse-fl2.zte.com.cn 64D8r4bc045011 X-MSS: AUDITRELEASE@mse-fl2.zte.com.cn X-TLS: YES X-SPF-DOMAIN: zte.com.cn X-ENVELOPE-SENDER: liu.qingtao2@zte.com.cn X-SPF: None X-SOURCE-IP: 10.5.228.133 unknown Wed, 13 May 2026 16:53:07 +0800 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 6A043BF3.000/4gFnKv3DD1z8Xs79 Thanks for your kindly review. Sorry for the delay. > On 13/02/2026 10:33, LiuQingtao wrote: > > From: Wenhong Liu > > > > Add documentation for LRW UART devicetree bindings. > > > > Signed-off-by: Wenhong Liu > > Signed-off-by: Qingtao Liu > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > > A nit, subject: drop second/last, redundant "bindings". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Thanks for the notice. I will change the subject to "Add devicetree binding for ZTE LRX UART controller" in the v2 patch series. > > --- > > .../bindings/serial/lrw,lrw-uart.yaml | 49 +++++++++++++++++++ > > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > > MAINTAINERS | 7 +++ > > 3 files changed, 58 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml > > > > diff --git a/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml b/Documentation/devicetree/bindings/> serial/lrw,lrw-uart.yaml > > new file mode 100644 > > index 000000000000..a2d41c278c4f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > + > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/serial/lrw-uart.yaml# > > Never tested, NAK. There are several other issues here, but I am not > going through rest of review if you did not bother to even build test > it. Please open any other recent binding and apply same style here > (filename, descriptions etc), so you won't be repeating SAME mistakes. > > Sorry, i tested on an older version kernel. No errors or warnings ever showed up running the command "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/zte,lrx-uart.yaml". Log from v2 patch: $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/zte,lrx-uart.yaml SCHEMA Documentation/devicetree/bindings/processed-schema.json CHKDT ./Documentation/devicetree/bindings LINT ./Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/serial/zte,lrx-uart.example.dts DTC [C] Documentation/devicetree/bindings/serial/zte,lrx-uart.example.dtb > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: LRW serial UART > > + > > +maintainers: > > + - Wenhong Liu > > + - Qingtao Liu > > + > > +description: | > > + Should be something similar to "lrw,-uart" > > + for the UART as integrated on a particular chip, It supports > > + multiple CPU architectures, currently including e.g. RISC-V and ARM. > > + > > +properties: > > + compatible: > > + const: lrw,lrw-uart > > No way lrw is a chip if this is a company. Sorry for the name problem. lrw is a subsidiary of ZTE. We will use ZTE as company name and lrx as chip name in the v2 patches. lrx is a chip that will be comming up soon. > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - current-speed > > + - clocks > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + uart0: serial@e0001800 { > > + compatible = "lrw,lrw-uart"; > > + interrupt-parent = <&aplic0>; > > + interrupts = <0x12 0x4>; > > + reg = <0xe0001800 0x100>; > > + clocks = <&bar_clk>; > > + current-speed = <115200>; > > + }; > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/> vendor-prefixes.yaml > > index ee7fd3cfe203..ec9bf262f466 100644 > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > @@ -961,6 +961,8 @@ patternProperties: > > description: Loongson Technology Corporation Limited > > "^loongmasses,.*": > > description: Nanjing Loongmasses Ltd. > > + "^lrw,.*": > > + description: LRW Corp. > > What is the website/domain address? > > > Best regards, > Krzysztof There won't be such problem since we use ZTE as company name. ZTE was described in Documentation/devicetree/bindings/vendor-prefixes.yaml already. Thanks, Qingtao Liu