Re: [PATCH v3 3/6] regulator: dt-bindings: mt6359: Deprecate bogus vcn33_[12]_* split regulators

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The regular expression for the deprecated regulators lacks the end-of-string anchor `$`, which could match unintended properties.
- [Low] The binding's example section was not updated to reflect the new, correct regulator definitions.
--

commit 75d8942658a7e71876edb163381baadd080c5c5f
Author: Chen-Yu Tsai <wenst@chromium.org>

regulator: dt-bindings: mt6359: Deprecate bogus vcn33_[12]_* split regulators

This commit deprecates the split vcn33_[12]_bt and vcn33_[12]_wifi regulators
because they refer to the same output. It adds the proper regulators vcn33_1
and vcn33_2 to match the actual outputs.

> diff --git a/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml b/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml
> index ac925334ae833..eb62d6a0355d9 100644
> --- a/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml
> @@ -30,7 +30,7 @@ patternProperties:
>      $ref: regulator.yaml#
>      unevaluatedProperties: false
>  
> -  "^ldo_vcn(18|13|33_1_bt|13_1_wifi|33_2_bt|33_2_wifi)$":
> +  "^ldo_vcn(18|13|33_[12])$":
>      type: object
>      $ref: regulator.yaml#
>      unevaluatedProperties: false

[ ... ]

> @@ -55,6 +55,15 @@ patternProperties:
>      $ref: regulator.yaml#
>      unevaluatedProperties: false
>  
> +  "^ldo_vcn33_[12]_(bt|wifi)":

Does this regex regression allow incorrectly named device tree nodes to pass
validation?

Without the $ anchor at the end, the regex will incorrectly match any property
name that merely starts with the pattern, such as ldo_vcn33_1_bt_invalid.

This would allow nodes with trailing characters to bypass the
additionalProperties: false restriction.

> +    type: object
> +    $ref: regulator.yaml#
> +    description:
> +      vcn33_[12]_(bt|wifi) are incorrect representations.
> +      Use vcn33_[12] instead.
> +    deprecated: true
> +    unevaluatedProperties: false
> +
>  additionalProperties: false
>  
>  examples:

Is there a regression here where the examples section was not updated to
reflect the new correct regulator definitions?

The examples block still defines the deprecated ldo_vcn33_1_bt,
ldo_vcn33_1_wifi, ldo_vcn33_2_bt, and ldo_vcn33_2_wifi nodes:

        mt6359_vcn33_1_bt_ldo_reg: ldo_vcn33_1_bt {
          regulator-name = "vcn33_1_bt";
          regulator-min-microvolt = <2800000>;
          regulator-max-microvolt = <3500000>;
        };

This can cause make dt_binding_check to issue deprecation warnings.

It could also potentially mislead developers who copy the example code into
their device trees.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512085358.1693208-1-wenst@chromium.org?part=3