Re: [PATCH v5 1/2] dt-bindings: input: Document Imagis ISA1200 haptic motor driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing scalar type definitions for `imagis,period-ns` and `imagis,duty-cycle-ns` cause schema bounds validation to be silently bypassed.
--

commit c2a7ef2ca3d62317c69bc5b6a450107172eeeac7
Author: Svyatoslav Ryhel <clamor95@gmail.com>

dt-bindings: input: Document Imagis ISA1200 haptic motor driver

This commit documents the Imagis ISA1200 haptic motor driver. It introduces
a new YAML binding schema for the driver, specifying properties like
control-gpios, clocks, and internal PWM configurations.

> diff --git a/Documentation/devicetree/bindings/input/imagis,isa1200.yaml b/Documentation/devicetree/bindings/input/imagis,isa1200.yaml
> new file mode 100644
> index 0000000000000..bbe6f99d39c19
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/imagis,isa1200.yaml
[ ... ]
> @@ -0,0 +1,140 @@
[ ... ]
> +  imagis,mode:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      Defines the motor type isa1200 drives
> +      0 - LRA (Linear Resonant Actuator)
> +      1 - ERM (Eccentric Rotating Mass)
> +    enum: [0, 1]
> +    default: 0
> +
> +  imagis,period-ns:
> +    description:
> +      Period of the internal PWM channel in nanoseconds.
> +    minimum: 10000
> +    maximum: 30000
> +
> +  imagis,duty-cycle-ns:
> +    description:
> +      Duty cycle of the external/internal PWM channel in nanoseconds,
> +      defaults to 50% of the channel's period

Will the minimum and maximum bounds on imagis,period-ns be silently ignored
during validation?

The core property-units.yaml schema automatically assigns an array type to
properties ending in -ns. Without an explicit reference to
/schemas/types.yaml#/definitions/uint32, these properties are evaluated as
arrays rather than scalar integers. 

In standard JSON Schema, numeric constraints like minimum and maximum are
ignored when applied to an array instance. Adding the uint32 type reference
for both imagis,period-ns and imagis,duty-cycle-ns would ensure the
constraints are properly enforced on a single scalar value.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512102445.55372-1-clamor95@gmail.com?part=1