Re: [PATCH v2 13/16] ARM: dts: mediatek: mt6323: add thermal support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The thermal zone node name `pmic_vts_thermal` contains underscores, which violates the DT schema validation rules for thermal zones.
--

commit b08a96e273f3be780a8e1efc4286fbc9434906b8
Author: Roman Vivchar <rva333@protonmail.com>

ARM: dts: mediatek: mt6323: add thermal support

Add the devicetree node for the mt6323 thermal.

> diff --git a/arch/arm/boot/dts/mediatek/mt6323.dtsi b/arch/arm/boot/dts/mediatek/mt6323.dtsi
> index 435936b477fa8..9825e15ab4e49 100644
> --- a/arch/arm/boot/dts/mediatek/mt6323.dtsi
> +++ b/arch/arm/boot/dts/mediatek/mt6323.dtsi

[ ... ]

> @@ -274,5 +286,24 @@ power-controller {
>  		rtc {
>  			compatible = "mediatek,mt6323-rtc";
>  		};
> +
> +		mt6323_thermal: thermal {
> +			compatible = "mediatek,mt6323-thermal";
> +			nvmem-cells = <&mt6323_thermal_calibration_data>;
> +
> +			io-channels = <&mt6323_adc MT6323_AUXADC_CHIP_TEMP>;
> +			#thermal-sensor-cells = <1>;
> +		};
> +	};
> +};
> +
> +/ {
> +	thermal-zones {
> +		pmic_vts_thermal {

Does this node name violate the device tree schema validation rules?

According to the thermal zone bindings, child nodes of thermal-zones must
match the regular expression ^[a-zA-Z][a-zA-Z0-9\-]{1,10}-thermal$. Because
this name contains underscores and ends with _thermal instead of -thermal, it
will fail validation.

Should this be renamed to use hyphens, such as pmic-vts-thermal?

> +			polling-delay-passive = <1000>;
> +			polling-delay = <1000>;
> +
> +			thermal-sensors = <&mt6323_thermal 0>;
> +		};
>  	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-mt6323-v2-0-3efcba579e88@protonmail.com?part=13