Re: [PATCH v3 2/3] arm64: dts: qcom: Add Eliza-specific PM7750BA dtsi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The commit message incorrectly references 'PM7750BA' instead of 'pm7550ba'.
- [Low] Unnecessary duplication of the entire `pm7550ba.dtsi` file to change the target SPMI bus.
--

commit 972447828c23a5ba2c8f03cd2dde21737ff3881a
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: Add Eliza-specific PM7750BA dtsi

This commit adds a new Device Tree Source Include file for the PM7550BA PMIC
on the Eliza platform. It introduces a separate variant to configure the
specific SPMI bus master used by the hardware.

> arm64: dts: qcom: Add Eliza-specific PM7750BA dtsi
> 
> On Eliza, the SPMI arbiter supports multiple bus masters, requiring
> explicit selection of the master for each PMIC.
> 
> The existing PM7750BA dtsi does not provide a way to describe this,

This isn't a bug, but there is a mismatch in the hardware name. The commit
subject and message reference PM7750BA, while the code introduces
pm7550ba-eliza.dtsi for the qcom,pm7550ba PMIC. Could these references be
updated to PM7550BA to match the hardware and file names?

> diff --git a/arch/arm64/boot/dts/qcom/pm7550ba-eliza.dtsi b/arch/arm64/boot/dts/qcom/pm7550ba-eliza.dtsi
> new file mode 100644
> index 0000000000000..2c386f16eca46
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm7550ba-eliza.dtsi
> @@ -0,0 +1,69 @@
[ ... ]
> +&spmi_bus0 {
> +	pm7550ba: pmic@7 {
> +		compatible = "qcom,pm7550ba", "qcom,spmi-pmic";

The commit message states this duplication is required due to hardware
differences in how the SPMI bus is exposed. However, this appears to be a
full copy of the existing pm7550ba.dtsi file just to change the target bus to
&spmi_bus0.

Could this be achieved with less code duplication by refactoring the original
pm7550ba.dtsi? 

If the hardcoded &spmi_bus wrapper were removed from the base file, callers
could directly include it under their appropriate bus node. Would that be a
cleaner approach to avoid the ongoing maintenance burden of keeping the
thermal zones and PMIC nodes synchronized across two identical files?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-eliza-adsp-usb-v3-0-6420282841c2@oss.qualcomm.com?part=2