Re: [PATCH v5 1/6] media: dt-bindings: Document SC8280XP/SM8350 Iris

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect YAML sequence indentation breaks `make dt_binding_check`.
--

commit 7d3ce999d6af6439f0c83bd8f368afdadb5e31c4
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

media: dt-bindings: Document SC8280XP/SM8350 Iris

The Iris block on SM8350 and SC8280XP is compatible with the Iris (Venus)
on SM8250. This commit updates the bindings to describe the block as Iris
v2 and documents the SM8350 and SC8280XP IP cores using a fallback
compatible string.

> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
> --- a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
> @@ -10,15 +10,21 @@ maintainers:
[ ... ]
>  properties:
>    compatible:
> -    const: qcom,sm8250-venus
> +    oneOf:
> +      - const: qcom,sm8250-venus
> +      - items:
> +        - enum:
> +            - qcom,sc8280xp-iris
> +            - qcom,sm8350-iris
> +        - const: qcom,sm8250-venus

Will this indentation cause `make dt_binding_check` to fail?

The kernel's Documentation/devicetree/bindings/.yamllint file enforces
indent-sequences: true with a 2-space indentation rule. This requires any
block sequence acting as a value for a mapping key to be indented further than
the key itself.

Here, the "- items:" element is at 6 spaces, placing the "items:" mapping key
conceptually at 8 spaces. The child sequence elements "- enum:" and "- const:"
are placed at 8 spaces, identical to the parent "items:" key, rather than being
indented inside it.

Yamllint typically expects the child sequence to be indented an additional 2
spaces (at 10 spaces) and will likely flag an indentation error.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-iris-sc8280xp-v5-0-8cc251e83b58@oss.qualcomm.com?part=1