From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3109E3BC68D for ; Wed, 13 May 2026 21:42:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778708525; cv=none; b=H8eYXTndm4JmQZ37Eohtip3bvOXC2XjPhlSZLcH3IQ1k28XcIfT66/lui60UvuPYzzxoHlEgpJpGk01tCL8BUZ1NVCAr4oZ8Y3f/A62IOdHfiugAAD+6i7ya4rwT3FfcpoZeeQc7JCOlps7Az5yx/1cI7eqjr2oLFTdKYMhjJog= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778708525; c=relaxed/simple; bh=XawclTxOGS7jlTgXDoKV3KDC+UQnxgsILXZ1rYTqd3Y=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=b5zOxRU461UmT5FJoNLY/E5Cr9T1y0cY46RctWib8i4ZEvAGt/tdc5q/YCh13nv3mBwq2G9iqsje6AhrZwldhqIdAuGuWctvdi2EhYnp4p7FWZS7QYr4mnQ8CahgyoTAz5QPaInpTr2vLyoB1KXybb/vsZfYlm6irtU3HWzzbgE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kfn5gwqm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kfn5gwqm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BD77C2BCB8; Wed, 13 May 2026 21:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778708524; bh=XawclTxOGS7jlTgXDoKV3KDC+UQnxgsILXZ1rYTqd3Y=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=kfn5gwqm+Bc/cJAWDmR9LYHFGUsxyWH8MixnfCCrUhYkns3PVT/cxhXLeQK6i8iMG Rq6w5tBGfVir8INzAIHpU+0o+frQsTLpQC9yBASLCkPjq4FuVVCC/Onw0aQ7UzNSty 8qDrSA60u14xHLW3FNKpcB4EDaFN8GzZCqX2VKJ/TEr9PIsNGq4kHMKoUDiCXFXl3Y l2saxBrilAQWms2eXKxvZwCA/81RYe07v9BuFNEZ24kUrG8EriWgiXhqAAkLKDK6ip tiWiqR9VqTGolrwP9XphZBaElvvpMwDn+9kBR3/wFkfkmm/XU94at0Uv8/hvJWuWU0 FLHpGAjaddbNg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 1/2] arm64: dts: qcom: sm8250: sort out Iris power domains Reply-To: sashiko-reviews@lists.linux.dev To: "Dmitry Baryshkov" Cc: conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260512-iris-venus-fix-sm8250-v6-1-51856dbef83c@oss.qualcomm.com> References: <20260512-iris-venus-fix-sm8250-v6-1-51856dbef83c@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 13 May 2026 21:42:03 +0000 Message-Id: <20260513214204.7BD77C2BCB8@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [High] The Venus driver ignores the newly added 'mmcx' power domain, prev= enting its voltage levels from being scaled or enabled. - [Low] The addition of a fourth power domain violates the existing device = tree binding schema for the Venus node. - [Low] Duplicate phandles to the same OPP table in `required-opps` violate= the `opp-v2` device tree binding schema. -- commit b2dff816f619c94b6f1db957c2bb928b6d9248f2 Author: Dmitry Baryshkov arm64: dts: qcom: sm8250: sort out Iris power domains This commit adds the MMCX power domain to the Iris device node on SM8250 to support MMCX voltage levels. It updates the power-domains, power-domain-names, and required-opps properties. > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/q= com/sm8250.dtsi > index 7076720413ab2..1fcbd400a3be3 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -4326,8 +4326,12 @@ venus: video-codec@aa00000 { > interrupts =3D ; > power-domains =3D <&videocc MVS0C_GDSC>, > <&videocc MVS0_GDSC>, > - <&rpmhpd RPMHPD_MX>; > - power-domain-names =3D "venus", "vcodec0", "mx"; > + <&rpmhpd RPMHPD_MX>, > + <&rpmhpd RPMHPD_MMCX>; > + power-domain-names =3D "venus", > + "vcodec0", > + "mx", > + "mmcx"; Does this addition cause a device tree schema regression? The schema in Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml currently enforces maxItems: 3 for power-domains and restricts power-domain-names to exactly "venus", "vcodec0", and "mx". Will the qcom/venus driver actually attach to this new mmcx power domain? Looking at drivers/media/platform/qcom/venus/pm_helpers.c, vcodec_domains_get() initializes opp_pd_data with num_pd_names =3D 1, and t= he hardware resource struct sm8250_res.opp_pmdomain in core.c only lists { "mx" }. Since "mmcx" is not in this array, devm_pm_domain_attach_list() will only attach "mx". This would cause opp_table->required_devs[1] to remain NULL, and the OPP core might silently skip setting the performance state for MMCX. Does the driver need an update to properly manage the MMCX rail? [ ... ] > @@ -4353,22 +4357,26 @@ venus_opp_table: opp-table { > =20 > opp-720000000 { > opp-hz =3D /bits/ 64 <720000000>; > - required-opps =3D <&rpmhpd_opp_low_svs>; > + required-opps =3D <&rpmhpd_opp_low_svs>, > + <&rpmhpd_opp_low_svs>; Could these duplicate phandles cause a schema validation regression? The opp-v2 bindings in Documentation/devicetree/bindings/opp/opp-v2-base.ya= ml explicitly state that required-opps should not contain multiple phandles to the OPP nodes in the same OPP table. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260512-iris-venus= -fix-sm8250-v6-0-51856dbef83c@oss.qualcomm.com?part=3D1