From: sashiko-bot@kernel.org
To: "Josua Mayer" <josua@solid-run.com>
Cc: robh@kernel.org, conor+dt@kernel.org,
wsa+renesas@sang-engineering.com, devicetree@vger.kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH v3 3/4] arm64: dts: renesas: add support for solidrun rzv2l som and hb-iiot evb
Date: Wed, 13 May 2026 21:42:30 +0000 [thread overview]
Message-ID: <20260513214230.C9EF6C19425@smtp.kernel.org> (raw)
In-Reply-To: <20260512-rzg2-sr-boards-v3-3-f033fc96c906@solid-run.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The eMMC and microSD standalone overlays are omitted from dtb-$(CONFIG_ARCH_R9A07G054) targets.
--
commit 2aa4e018f2033b5a47eb3f69fb35447ebe753d2f
Author: Josua Mayer <josua@solid-run.com>
arm64: dts: renesas: add support for solidrun rzv2l som and hb-iiot evb
This commit adds support for the SolidRun RZ/V2L SoM on the Hummingboard
IIoT carrier board. Due to similarities with the RZ/G2L, it shares most code
and device tree overlays.
Link: https://www.solid-run.com/embedded-industrial-iot/renesas-rz-family/rz-v2l-som/
Link: https://www.solid-run.com/embedded-industrial-iot/renesas-rz-family/hummingboard-rz-series-sbcs/hummingboard-rz-g2l-iot-sbc/
> diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
> index 38163ce845e7a..cff17cb8574a3 100644
> --- a/arch/arm64/boot/dts/renesas/Makefile
> +++ b/arch/arm64/boot/dts/renesas/Makefile
> @@ -188,6 +188,17 @@ dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc-cru-csi-ov5645.dtbo
> r9a07g044l2-smarc-cru-csi-ov5645-dtbs := r9a07g044l2-smarc.dtb r9a07g044l2-smarc-cru-csi-ov5645.dtbo
> dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc-cru-csi-ov5645.dtb
>
> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-iiot.dtb
> +r9a07g054l2-hummingboard-iiot-emmc-dtbs := r9a07g054l2-hummingboard-iiot.dtb rzg2l-sr-som-emmc.dtbo
> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-iiot-emmc.dtb
> +r9a07g054l2-hummingboard-iiot-microsd-dtbs := r9a07g054l2-hummingboard-iiot.dtb rzg2l-hummingboard-iiot-microsd.dtbo
> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-iiot-microsd.dtb
Are we missing standalone dtb-$(CONFIG_ARCH_R9A07G054) entries for the emmc
and microsd overlays here?
> +dtb-$(CONFIG_ARCH_R9A07G054) += rzg2l-hummingboard-iiot-rs485-a.dtbo
> +r9a07g054l2-hummingboard-iiot-rs485-a-dtbs := r9a07g054l2-hummingboard-iiot.dtb rzg2l-hummingboard-iiot-rs485-a.dtbo
> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-iiot-rs485-a.dtb
> +dtb-$(CONFIG_ARCH_R9A07G054) += rzg2l-hummingboard-iiot-rs485-b.dtbo
> +r9a07g054l2-hummingboard-iiot-rs485-b-dtbs := r9a07g054l2-hummingboard-iiot.dtb rzg2l-hummingboard-iiot-rs485-b.dtbo
> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-iiot-rs485-b.dtb
The rs485-a and rs485-b overlays are explicitly added to the build targets
above, which ensures they are copied to the output directory during make
dtbs_install.
If a user compiles a kernel exclusively for RZ/V2L where
CONFIG_ARCH_R9A07G054=y but CONFIG_ARCH_R9A07G044 is disabled, will
the emmc and microsd overlays fail to install as standalone files?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-rzg2-sr-boards-v3-0-f033fc96c906@solid-run.com?part=3
next prev parent reply other threads:[~2026-05-13 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 13:00 [PATCH v3 0/4] arm64: dts: renesas: Add various SolidRun RZ/G2 based boards Josua Mayer
2026-05-12 13:00 ` [PATCH v3 1/4] dt-bindings: soc: " Josua Mayer
2026-05-12 17:06 ` Conor Dooley
2026-05-13 9:00 ` Josua Mayer
2026-05-13 18:08 ` Conor Dooley
2026-05-12 13:00 ` [PATCH v3 2/4] arm64: dts: renesas: add support for solidrun rzg2l som and hb-iiot evb Josua Mayer
2026-05-13 21:31 ` sashiko-bot
2026-05-12 13:00 ` [PATCH v3 3/4] arm64: dts: renesas: add support for solidrun rzv2l " Josua Mayer
2026-05-13 21:42 ` sashiko-bot [this message]
2026-05-12 13:00 ` [PATCH v3 4/4] arm64: dts: renesas: add support for solidrun rzg2lc " Josua Mayer
2026-05-13 21:59 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513214230.C9EF6C19425@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=josua@solid-run.com \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox