Re: [PATCH v4 2/2] pinctrl: qcom: Add Shikra pinctrl driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The Kconfig symbol PINCTRL_SHIKRA incorrectly uses `default ARCH_QCOM`, which is inconsistent with the rest of the pinctrl drivers in the subsystem.
--

commit 635e77fc90eb7d688d1990612274cdff1b91f42d
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>

pinctrl: qcom: Add Shikra pinctrl driver

This commit adds the pinctrl driver for the TLMM block found in the
Qualcomm Shikra SoC.

> diff --git a/drivers/pinctrl/qcom/Kconfig.msm b/drivers/pinctrl/qcom/Kconfig.msm
> index 836cdeca1006f..20e1068492734 100644
> --- a/drivers/pinctrl/qcom/Kconfig.msm
> +++ b/drivers/pinctrl/qcom/Kconfig.msm
[ ... ]
> @@ -369,6 +369,17 @@ config PINCTRL_SDX75
>           Qualcomm Technologies Inc TLMM block found on the Qualcomm
>           Technologies Inc SDX75 platform.
>  
> +config PINCTRL_SHIKRA
> +	tristate "Qualcomm Shikra pin controller driver"
> +	depends on ARM64 || COMPILE_TEST
> +	default ARCH_QCOM

Is this default intended? Looking at the other SoC-specific pin controller
drivers in this file, such as PINCTRL_SM4450 just below this, they do not
appear to use default ARCH_QCOM.

Defining it here forces this driver to be built by default whenever the
generic ARCH_QCOM is enabled, which seems inconsistent with the established
pattern for the rest of the subsystem.

> +	help
> +	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> +	  Qualcomm Technologies Inc Top Level Mode Multiplexer block (TLMM)
> +	  found on the Qualcomm	Technologies Inc Shikra platform.
> +	  Say Y here to compile statically, or M here to compile it as a module.
> +	  If unsure, say N.
> +
>  config PINCTRL_SM4450
>  	tristate "Qualcomm Technologies Inc SM4450 pin controller driver"
>  	depends on ARM64 || COMPILE_TEST
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-shikra-pinctrl-v4-0-b93c3a2e4c08@oss.qualcomm.com?part=2