From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D878538E120; Wed, 13 May 2026 22:51:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778712702; cv=none; b=bbEX5eBNqxZBJoW+YDiv4YvAN7cA/ljuI3uprjclSup/QeMMM0j8OCGZb0byxyoToQdqZSSZob/GWgtzM3BFPNU18ZCuCw8yYsZWUI7MsVNdvYQhjQKppW9dQB3VhDxOUwO18MngUOjKTOdXOS9Sgwh4QsH2dg6JxpYcPL0ZL7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778712702; c=relaxed/simple; bh=wUMpwhwilzNmRvbXOEo9SAv3BseRKnCQdVuFjH9lNqA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c/H+Pd8/GWxPw7KRaWBGz+AqJkbzbvSR+775gGXJBqt2luFh6ZWnA+YzcfRfxNsQBiw92UbFmQi4qiQS+INF/Zv7yPVFLfEybWI5rJubgFE36lg/bqJR9GRB6XJor5Ta/zbJ6wt51+j3ZiChU0K+Bnfmkkkc/OLk9xkGGQxoWf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GyikPo6j; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GyikPo6j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFA97C19425; Wed, 13 May 2026 22:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778712702; bh=wUMpwhwilzNmRvbXOEo9SAv3BseRKnCQdVuFjH9lNqA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GyikPo6jz4MU5gqJ/qUXTLTCmrzOP37ZEtVlCDl9bu3v5sFbCg00OW2GW73GLddNw VtNueE5GPRhPOt+P/1fKAXI15cg4hWOX4yky3fBI9mVJb/zQD9gK59YyVzX+EJGqFG rVO3C/avEOavbcKWd0MkiQh3rDbL0utUEgLVeH4MIJlGJj3CrEL+6mh4FUgG3KPQEv iVaY5m+d0OSKQY5lwXcjHAsUwOtld1FOxiDYOjMElyFI3HLX1SOovIOK4dxt35lk6L Enz57ctHnxRFHcZ9EImBaMet7zyaT2883jCQwTMIpWp8x0oG8tj+ibHqRVpCNXQlx/ C5X2VM5cHDclw== Date: Wed, 13 May 2026 17:51:38 -0500 From: Rob Herring To: Loic Poulain Cc: Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Kees Cook , "Gustavo A. R. Silva" , Bryan O'Donoghue , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, devicetree@vger.kernel.org, laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, johannes.goede@oss.qualcomm.com Subject: Re: [PATCH v3 10/15] dt-bindings: media: qcom,qcm2290-camss: Add OPE ISP subnode Message-ID: <20260513225138.GA2234805-robh@kernel.org> References: <20260508-camss-isp-ope-v3-0-bb1055274603@oss.qualcomm.com> <20260508-camss-isp-ope-v3-10-bb1055274603@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260508-camss-isp-ope-v3-10-bb1055274603@oss.qualcomm.com> On Fri, May 08, 2026 at 12:49:25AM +0200, Loic Poulain wrote: > Extend the qcm2290 CAMSS binding to describe CAMSS as a simple bus by > allowing child ISP nodes. Add the required address and size cells, as > well as ranges, and validate ISP subnodes against the existing > qcom,qcm2290-camss-ope schema. > > On qcm2290 the OPE (Offline Processing Engine) is a memory-to-memory > ISP (Image Signal Processor). > > The address-cells for the CAMSS bus is <2> (64-bit) as related > DMA/IOMMUs offer 36-bit addressing support. > > Signed-off-by: Loic Poulain > --- > .../devicetree/bindings/media/qcom,qcm2290-camss.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml > index 391d0f6f67ef5fdfea31dd3683477561516b1556..e70f4cd1348b8065ee9f0e4448185cfd8a8fb7de 100644 > --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml > @@ -52,6 +52,14 @@ properties: > - const: vfe1 > - const: vfe1_cphy_rx > > + "#address-cells": > + const: 2 > + > + "#size-cells": > + const: 2 > + > + ranges: true > + > interrupts: > maxItems: 8 > > @@ -117,6 +125,11 @@ properties: > required: > - data-lanes > > +patternProperties: > + "^isp@[0-9a-f]+$": > + $ref: /schemas/media/qcom,qcm2290-camss-ope.yaml > + unevaluatedProperties: false The referenced schema will get applied twice. Instead, just define here what compatible must be present. IIRC, the QCom display bindings are structured like that if you need an example. Rob