Re: [PATCH v6 10/10] arm64: dts: Add support for LX2160 Twins board in single configuration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused USB port left enabled despite the board only having a single port.
--

commit f3287c94b8a1489521dd5dfc2f4009ec55b9a33c
Author: Josua Mayer <josua@solid-run.com>

arm64: dts: Add support for LX2160 Twins board in single configuration

This commit adds device tree support for the SolidRun LX2160A Twins board
in a single CPU configuration. It defines the various hardware interfaces
available on the board.

> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-half-twins.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-half-twins.dts
> new file mode 100644
> index 0000000000000..ee1867f5b2b6b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-half-twins.dts
> @@ -0,0 +1,826 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for single LX2160A CEX-7 on Twins board.
> +//
> +// Copyright 2022 SolidRun Ltd.
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/leds/common.h>
> +
> +#include "fsl-lx2160a-rev2.dtsi"
> +#include "fsl-lx2160a-cex7.dtsi"

The commit message states the configuration features a "USB-3.0 front-panel
header with single port", and no other USB ports are listed.

Since the included fsl-lx2160a-cex7.dtsi unconditionally sets the status to
"okay" for both usb0 and usb1, does this regression leave the non-existent
second USB port enabled?

Should this board-specific device tree explicitly disable the unused port,
perhaps by adding &usb1 { status = "disabled"; }; ?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-lx2160-pci-v6-0-d0ff72d3c983@solid-run.com?part=10