Re: [PATCH] dt-bindings: fpga: altr,socfpga-fpga-mgr: convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The 'maintainers' list incorrectly includes Steffen Trumtrar and Rob Herring.
--

commit be1c0ecc6a9857f9aa82bd84bf85fccfa1cb035c
Author: Manish Baing <manishbaing2789@gmail.com>

dt-bindings: fpga: altr,socfpga-fpga-mgr: convert to DT schema

This commit converts the Altera SoCFPGA FPGA Manager bindings from the legacy
text format to a YAML schema.

[ ... ]

> diff --git a/Documentation/devicetree/bindings/fpga/altr,socfpga-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/altr,socfpga-fpga-mgr.yaml
> new file mode 100644
> index 0000000000000..d09d552dde5e9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/altr,socfpga-fpga-mgr.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fpga/altr,socfpga-fpga-mgr.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Altera SOCFPGA FPGA Manager
> +
> +maintainers:
> +  - Steffen Trumtrar <s.trumtrar@pengutronix.de>
> +  - Rob Herring <robh@kernel.org>

Are these the intended maintainers for this specific binding?

Steffen Trumtrar does not appear to be the original author of the text
binding, and is not listed in the MAINTAINERS file for the FPGA manager
framework or the Altera SOCFPGA architecture. 

Additionally, while Rob Herring is the general Devicetree maintainer,
the general guidance is to avoid listing him as the dedicated maintainer
for specific vendor schemas unless he authored them.

Would it be better to list the FPGA subsystem maintainers (such as Moritz
Fischer or Xu Yilun) or the original author of the text binding here so
the get_maintainer.pl script routes queries to the right people?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512165058.64049-1-manishbaing2789@gmail.com?part=1