Re: [PATCH] Enable wifi on the BeagleV-Ahead

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Missing mandatory fallback compatible string `brcm,bcm4329-fmac` silently breaks driver interrupt parsing.
- [Low] Pinctrl node names violate the `thead,th1520-pinctrl` schema constraints.
--

commit 36b13556394c8110c85a42dc09295453444c2a36
Author: Thomas Gerner <thomas.gerner@muenchen-mail.de>

Enable wifi on the BeagleV-Ahead
    
The BeagleV-Ahead board uses an AP6203BM WiFi chip from AMPAK Technology
Inc. connected to SDIO1.

> diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
> index 91f3f9b987bc3..86da4bd8ceaf9 100644
> --- a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
> +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
[ ... ]
> @@ -239,6 +244,28 @@ rx-pins {
>  			slew-rate = <0>;
>  		};
>  	};
> +
> +	wifi_pins: wifi-pins {
> +		host-wake-wl {

Does this naming follow the thead,th1520-pinctrl schema constraints?

The schema requires pad group nodes to match the regex -[0-9]+$ (for
example, wifi-0) and inner pin-mux child nodes to match -pins$ (for
example, host-wake-pins).

Using wifi-pins and host-wake-wl / reg-on-wl will trigger dtbs_check
validation errors.

> +			pins = "GPIO2_25";
> +			function = "gpio";
> +			bias-disable;
> +			drive-strength = <1>;
> +			input-enable;
> +			input-schmitt-disable;
> +			slew-rate = <0>;
> +		};
> +
> +		reg-on-wl {
[ ... ]
> +	wifi@1 {
> +		compatible = "cypress,cyw43012-fmac";

Does this compatible string need the brcm,bcm4329-fmac fallback?

In drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c, brcmf_of_probe()
explicitly checks for this fallback:

	if (!of_device_is_compatible(np, "brcm,bcm4329-fmac"))
		return;

Without the fallback string, the driver skips parsing the interrupts
property, which breaks the wake-on-WLAN functionality intended by
configuring the host-wake pin.

> +		reg = <1>;
> +		interrupt-parent = <&gpio2>;
> +		interrupts = <25 IRQ_TYPE_EDGE_RISING>;
> +		interrupt-names = "host-wake";
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512173440.163179-1-thomas.gerner@muenchen-mail.de?part=1