From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F28AC390CA9; Thu, 14 May 2026 18:53:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778784817; cv=none; b=S6wN/hYYqXLxSsv6MqYlff+y5aifN/cy2FBXn2w01EleREGjArIhGv7M5y5HxQv+kOiFNIiG7KT3ivQwt4GINoXDOx+vhjDUDBUinuCIQzNwF6TOs07WvfNEMw2Gy9j+BP5lUHnes1YNOtcx6RkpC35ARyRVX6zHYJdlrrBCiJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778784817; c=relaxed/simple; bh=LojdqSQPYBF5kOn8K4ij6P5PAbYy892VG0hBX1AfX/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WeGnnYaNjpNNIyFmftiQCksqeI8gxcODh7UXFYRMM+2cXxEG/5JGNKpHOWLlyzC9XQDDuqLuAVNe+oCbkuMaad9bBwLzxI5PLt8xDUS1yH9+kJn4FSC1m/EvKEGpDFU8iligGN/v8+ey8OGPhEcjc1NHKUeNmXCI510+NTYKFV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SwIKUlZZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SwIKUlZZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0939C2BCB3; Thu, 14 May 2026 18:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778784816; bh=LojdqSQPYBF5kOn8K4ij6P5PAbYy892VG0hBX1AfX/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SwIKUlZZXtg28j72IRi90fQR8j5y6N5LCi0+Wuqq2IiiKkizMKGRpFy29n0M0sAUp hmgZVEtYBzMIXBJLeyCE95RyAeWijMiSDUB+RRZVDqfHzlH0RhmSrThL50vRKjHBKJ ISByx5wjy4tqlWcp3JO/gYA5uNTmfdNsJza52oBs90/lcYORa+3PSd7xG6pQ3EV5Zv Oz9587SQSkgHJSv2xHSwZ2rFQLon2sWTb3jkT9FymtZwXxuXSWr7t/UikDndJD/LcZ 7MUsEYLEk0X2pKeM5bZJaY394+1rdJ4VLAcVaJRhhzQiKLadZ29UtGemOm76bLFOIR cj1Ug44Vgu+KQ== Date: Thu, 14 May 2026 19:53:31 +0100 From: Conor Dooley To: Aaron Kling Cc: Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Teguh Sobirin Subject: Re: [PATCH v2 2/2] drm/panel: Add panel driver for Chipone ICNA35XX based panels Message-ID: <20260514-ability-ditch-b9194a93227f@spud> References: <20260514-icna35xx-v2-0-45acd1dfa566@gmail.com> <20260514-icna35xx-v2-2-45acd1dfa566@gmail.com> <20260514-sphere-overstep-e564bf7ca609@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LH9x5Wis7azuK+VC" Content-Disposition: inline In-Reply-To: --LH9x5Wis7azuK+VC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 14, 2026 at 01:24:19PM -0500, Aaron Kling wrote: > On Thu, May 14, 2026 at 1:05=E2=80=AFPM Conor Dooley w= rote: > > > > On Thu, May 14, 2026 at 12:24:50PM -0500, Aaron Kling via B4 Relay wrot= e: > > > > > +static const struct of_device_id icna35xx_of_match[] =3D { > > > + { .compatible =3D "ayaneo,pocketds-panel-top", .data =3D &odin2= portal_desc }, > > > + { .compatible =3D "ayntec,odin2portal-panel", .data =3D &odin2p= ortal_desc }, > > > + { .compatible =3D "ayntec,odin3-panel", .data =3D &thor_top_des= c }, > > > + { .compatible =3D "ayntec,thor-panel-top", .data =3D &thor_top_= desc }, > > > > This looks like you could be using the fallback compatibles instead of > > matching on the panel's. Why aren't you? >=20 > I'm uncertain if the panels are actually the same between these > devices or if the init sequences are just similar enough to share. I > am told that the thor top panel and the odin 3 panel are the same > model. But I don't know about the portal and the pocket ds, just know > that they both fire up and work as expected with the same init > sequence. I'm trying to follow the bindings idea that these might be > different physical panels that only share a ddic and thus driver > handling. That's a reasonable rationale. Could you include this in your commit message please? >=20 > > > + { /* sentinel */ } >=20 > Aaron --LH9x5Wis7azuK+VC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCagYaKwAKCRB4tDGHoIJi 0pW2AP99vZlg9sg3BFdlVMbpLtSekLQr/+4ZVTe/Qg6zB97dWQEA6oGr4N0iVOfI /G47jkjtB6w+EZMnfucgztmPdPzsyAc= =U4cC -----END PGP SIGNATURE----- --LH9x5Wis7azuK+VC--