Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vyacheslav Yurkov <V.Yurkov.EXT@bruker.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org,  linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org,
	 Vyacheslav Yurkov <uvv.mail@gmail.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: Add GPIO locked fixed clock
Date: Thu, 14 May 2026 14:11:07 +0200	[thread overview]
Message-ID: <20260514-authentic-meticulous-baboon-a1eeee@quoll> (raw)
In-Reply-To: <20260510-feature-clock-guard-v2-2-6c25458d5340@bruker.com>

On Sun, May 10, 2026 at 06:06:23PM +0000, Vyacheslav Yurkov wrote:
> Describe device tree binding for a fixed clock, which state can only be
> determined by the external GPIO. It's similar to gated-fixed-clock, but
> the GPIO direction is inverted.

v1 comments - do not ask us to repeat them.

"Please explain how I would identify this h/w."

> 
> Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
> Signed-off-by: Vyacheslav Yurkov <V.Yurkov.EXT@bruker.com>
> ---
>  .../bindings/clock/gpio-locked-fixed-clock.yaml    | 77 ++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/gpio-locked-fixed-clock.yaml b/Documentation/devicetree/bindings/clock/gpio-locked-fixed-clock.yaml
> new file mode 100644
> index 000000000000..e0256bbd441d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/gpio-locked-fixed-clock.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/gpio-locked-fixed-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPIO Locked Fixed Clock
> +
> +maintainers:
> +  - Vyacheslav Yurkov <V.Yurkov.EXT@bruker.com>
> +
> +description: |
> +  Clock controller that aggregates input clocks and/or GPIO
> +  signals and exposes them as a single clock output.

So same comments as before. We gave you multiple comments, multiple
expectations.

I see here no real hardware explanation and I asked for it more than
ONCE.

Best regards,
Krzysztof


  parent reply	other threads:[~2026-05-14 12:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 18:06 [PATCH v2 0/2] A proposal to add a gpio-locked fixed clock driver Vyacheslav Yurkov via B4 Relay
2026-05-10 18:06 ` [PATCH v2 1/2] clk: Add gpio-locked " Vyacheslav Yurkov via B4 Relay
2026-05-11 21:56   ` sashiko-bot
2026-05-10 18:06 ` [PATCH v2 2/2] dt-bindings: Add GPIO locked fixed clock Vyacheslav Yurkov via B4 Relay
2026-05-11 22:06   ` sashiko-bot
2026-05-14 12:11   ` Krzysztof Kozlowski [this message]
2026-05-14 12:12 ` [PATCH v2 0/2] A proposal to add a gpio-locked fixed clock driver Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260514-authentic-meticulous-baboon-a1eeee@quoll \
    --to=krzk@kernel.org \
    --cc=V.Yurkov.EXT@bruker.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=uvv.mail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox