Re: [PATCH 1/1] dt-bindings: display: imx: Add television encoder (TVE) for imx53

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing conditional constraints for VGA mode sync pins.
- [Low] The `fsl,tve-mode` property lacks a defined default and is not required.
--

commit 18cf39d8e659ce17f310f753763d63085e707e24
Author: Frank Li <Frank.Li@nxp.com>

dt-bindings: display: imx: Add television encoder (TVE) for imx53

This commit adds the device tree binding schema for the Freescale i.MX53
Television Encoder (TVE). It documents properties required to configure
the TVE module, which converts digital video to analog TV signals.

> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx53-tve.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx53-tve.yaml
> new file mode 100644
> index 0000000000000..a7c971be1959b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx53-tve.yaml
> @@ -0,0 +1,102 @@

[ ... ]

> +  fsl,tve-mode:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      TVE output mode selection.
> +    enum:
> +      - ntsc
> +      - pal
> +      - vga

Since fsl,tve-mode is not listed in the required properties, should it have
a default value defined to clarify what output mode the device assumes when
this property is absent?

> +
> +  fsl,hsync-pin:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Pin number for horizontal sync signal in VGA mode.
> +    minimum: 0
> +    maximum: 8
> +
> +  fsl,vsync-pin:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Pin number for vertical sync signal in VGA mode.
> +    minimum: 0
> +    maximum: 8

Is it necessary to add an allOf conditional block to enforce the dependency
between these sync pins and VGA mode?

Without it, device trees could pass validation while specifying these pins
for incompatible modes like NTSC or PAL, or they might omit them entirely
when VGA mode is selected.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512223137.1190096-1-Frank.Li@nxp.com?part=1