From: sashiko-bot@kernel.org
To: "Frank Li" <Frank.Li@nxp.com>
Cc: krzk+dt@kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, Frank.Li@kernel.org, conor+dt@kernel.org,
robh@kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: regulator: convert ltc3589 to yaml format
Date: Thu, 14 May 2026 00:18:58 +0000 [thread overview]
Message-ID: <20260514001859.6C352C19425@smtp.kernel.org> (raw)
In-Reply-To: <20260512224544.1223283-1-Frank.Li@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML binding schema omits the `interrupts` property, which breaks schema validation for valid hardware configurations that use the PMIC's interrupt line.
--
commit 6cc3d4149b88e8fe5fe483876ec1bdf0a91a59e7
Author: Frank Li <Frank.Li@nxp.com>
dt-bindings: regulator: convert ltc3589 to yaml format
Convert the Linear Technology LTC3589/LTC3589-1/LTC3589-2 regulator
binding from text to yaml format.
> diff --git a/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml b/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml
[ ... ]
> +properties:
> + compatible:
> + enum:
> + - lltc,ltc3589
> + - lltc,ltc3589-1
> + - lltc,ltc3589-2
> +
> + reg:
> + maxItems: 1
> +
> + regulators:
[ ... ]
> +required:
> + - compatible
> + - reg
> + - regulators
> +
> +additionalProperties: false
Does this conversion accidentally drop support for the interrupts property?
The LTC3589 driver in drivers/regulator/ltc3589.c checks for and requests
an IRQ using client->irq to handle internal regulator events like thermal
warnings and under-voltage.
Since the schema enforces additionalProperties: false at the top level,
valid device tree configurations that define the physical interrupt
connection for this PMIC will be rejected by dtbs_check.
Should interrupts (e.g. with maxItems: 1) be explicitly permitted in the
properties list?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260512224544.1223283-1-Frank.Li@nxp.com?part=1
prev parent reply other threads:[~2026-05-14 0:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 22:45 [PATCH 1/1] dt-bindings: regulator: convert ltc3589 to yaml format Frank Li
2026-05-13 1:28 ` Mark Brown
2026-05-14 0:18 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514001859.6C352C19425@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox