From: sashiko-bot@kernel.org
To: "Alexey Klimov" <alexey.klimov@linaro.org>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: firmware: google,gs101-acpm-ipc: document Exynos850 compatible
Date: Thu, 14 May 2026 00:21:34 +0000 [thread overview]
Message-ID: <20260514002134.98973C19425@smtp.kernel.org> (raw)
In-Reply-To: <20260513-exynos850-acpm-firmware-support-v1-1-3858d097e433@linaro.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree binding schema incorrectly applies GS101-specific PMIC constraints to the Exynos850 compatible string, preventing Exynos850 from legally defining its own PMIC child nodes.
--
commit 2c572cafffcf509acd05fb4e87547a118f399795
Author: Alexey Klimov <alexey.klimov@linaro.org>
dt-bindings: firmware: google,gs101-acpm-ipc: document Exynos850 compatible
This commit adds a new compatible string, samsung,exynos850-acpm-ipc, to the
ACPM IPC binding for the Exynos850 SoC. The hardware block requires a dedicated
compatible string due to differences in the initialization data base offset.
> diff --git a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml
> index e68f9c3ca5e26..511c873280fed 100644
> --- a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml
> +++ b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml
> @@ -22,7 +22,9 @@ description: |
>
> properties:
> compatible:
> - const: google,gs101-acpm-ipc
> + enum:
> + - google,gs101-acpm-ipc
> + - samsung,exynos850-acpm-ipc
Does this introduce a regression by unintentionally applying GS101-specific
PMIC constraints to the Exynos850 hardware?
Looking at the rest of the binding schema, pmic-1 is constrained to
samsung,s2mpg10-pmic and pmic-2 is constrained to samsung,s2mpg11-pmic. With
additionalProperties set to false at the top level and no conditional blocks
to distinguish between compatible strings, an Exynos850 device tree cannot
legally define its own hardware-specific PMIC child nodes without failing
schema validation.
Should there be conditional blocks to ensure the GS101 PMIC constraints only
apply when google,gs101-acpm-ipc is used?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-exynos850-acpm-firmware-support-v1-0-3858d097e433@linaro.org?part=1
next prev parent reply other threads:[~2026-05-14 0:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 23:12 [PATCH 0/2] Initial Exynos850 ACPM support for exynos-acpm Alexey Klimov
2026-05-12 23:12 ` [PATCH 1/2] dt-bindings: firmware: google,gs101-acpm-ipc: document Exynos850 compatible Alexey Klimov
2026-05-14 0:21 ` sashiko-bot [this message]
2026-05-12 23:12 ` [PATCH 2/2] firmware: samsung: acpm: add Exynos850 support Alexey Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514002134.98973C19425@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexey.klimov@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox