From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D909A5C613 for ; Thu, 14 May 2026 02:28:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778725697; cv=none; b=V6t6bUpP0cdOLKYFvl1/Nn4NqgFfK7sPFCRKnjqqnF2xg032sb5WIqnqhT4KIHI2oYpIP+Y7iwmWx7nHCKmO4ccIP4wV1dJjsYZu4f8oGXW+OJR43KvLaY9j7DGsS6E180vKvYjRrE7f9GeJDik3SrjSMR/sOgSwiEkZT3kc5Mo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778725697; c=relaxed/simple; bh=nnHudenjuSEGPyitNi65Tcf0PTHqH3TpWM0Mi7MEChw=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=AIKmHIKLu6onzJPw2We5Epi4OKKQ65h9Kl1uRls6Y0FWyfwU4tEXVCYSKHj55hiOD4ZMKh+ffuY4ax5QXqwusRNSyxr73wi6kkw4CMbVQH/0MEhCdNmDvA7x1WraRssPiDkQTAtd96CCUPbYawmblVTYWMtj3Gx3CGXVejXR/sQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QK34Dw8C; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QK34Dw8C" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FCF8C2BCB3; Thu, 14 May 2026 02:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778725697; bh=nnHudenjuSEGPyitNi65Tcf0PTHqH3TpWM0Mi7MEChw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=QK34Dw8C+aC7/2in1+BKGBMcyiCoPDwnmkw32/vluO+97XknR/57+N+/+/NIA7+LQ hH6gmjv5FRVrBuu/cJ8OLW2bLEGR1bL98DnMdGJI7FsS1lbubTj0kY5JWKqrAzKjrP L9kqIen4HKd8v1cbi35wE1iQRBHBmQkdOfzJZu/tZu1lt4AobiK5iE4Fww/q/fhTaY 6Jcw9hOujbW3G2QceBHEZ0qd+aibpGN7PLaFeiEtAJz+vv9chh0zaFrP6sZOra7P4s hAnNIcaBDgwf0eV8AILs5otE3AS5lSOrp2qnmO7Bp3oUv86Yt5+i2D8Hpn0bmonS5U tIvNNg2renN4g== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 1/6] riscv: dts: spacemit: k1-musepi-pro: add PMIC and power infrastructure Reply-To: sashiko-reviews@lists.linux.dev To: "Andre Heider" Cc: krzk+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: <20260513071958.29574-2-a.heider@gmail.com> References: <20260513071958.29574-2-a.heider@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 14 May 2026 02:28:16 +0000 Message-Id: <20260514022817.2FCF8C2BCB3@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Regulator minimum voltage constraints are set too loosely on fix= ed board rails, risking hardware brownouts. -- commit 823adf1d7b0f1286cdd0e228119b713b02c36d2e Author: Andre Heider riscv: dts: spacemit: k1-musepi-pro: add PMIC and power infrastructure This commit enables i2c8 and adds the connected SpacemiT P1 PMIC with its related regulators for the board's power infrastructure and voltage regulation support. > diff --git a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts b/arch/riscv/= boot/dts/spacemit/k1-musepi-pro.dts > index 29e333b670cf0..e0b585c50014b 100644 > --- a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts > +++ b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts [ ... ] > @@ -72,6 +82,130 @@ &pdma { > status =3D "okay"; > }; > =20 > +&i2c8 { > + pinctrl-0 =3D <&i2c8_cfg>; > + pinctrl-names =3D "default"; > + status =3D "okay"; > + > + pmic@41 { > + compatible =3D "spacemit,p1"; > + reg =3D <0x41>; > + interrupts =3D <64>; [ ... ] > + dldoin1-supply =3D <&buck5>; > + dldoin2-supply =3D <&buck5>; > + > + regulators { [ ... ] > + buck3_1v8: buck3 { > + regulator-min-microvolt =3D <500000>; > + regulator-max-microvolt =3D <1800000>; Should these minimum bounds be restricted to match the exact hardware layout of the board? The labels buck3_1v8 and buck4_3v3 indicate these rails are wired for fixed 1.8V and 3.3V usage, but the regulator-min-microvolt allows them to scale down to 0.5V. Could this loose constraint risk hardware brownouts if a driv= er attempts dynamic voltage scaling on these rails? > + regulator-ramp-delay =3D <5000>; > + regulator-always-on; > + }; > + > + buck4_3v3: buck4 { > + regulator-min-microvolt =3D <500000>; > + regulator-max-microvolt =3D <3300000>; > + regulator-ramp-delay =3D <5000>; > + regulator-always-on; > + }; > + > + buck5: buck5 { > + regulator-min-microvolt =3D <500000>; > + regulator-max-microvolt =3D <3450000>; Since buck5 is used as the parent supply for the DLDOs (dldoin1-supply and dldoin2-supply), could the wide 0.5V minimum constraint allow the OS to drop its voltage below the necessary headroom needed to power the downstream DLDOs? > + regulator-ramp-delay =3D <5000>; > + regulator-always-on; > + }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260513071958.2957= 4-1-a.heider@gmail.com?part=3D1