Re: [PATCH v2 3/3] arm64: dts: allwinner: a523: add gpadc node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The GPADC node lacks the `#address-cells` and `#size-cells` properties, which are structurally necessary for its required child nodes.
--

commit df07d88a5b17a24a46e46a7d0f2fce1a78cc0218
Author: Michal Piekos <michal.piekos@mmpsystems.pl>

arm64: dts: allwinner: a523: add gpadc node

This commit adds the GPADC block description for the Allwinner A523 SoC to
the base device tree include file.

> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi

[ ... ]

> +		gpadc: adc@2009000 {
> +			compatible = "allwinner,sun55i-a523-gpadc";
> +			reg = <0x2009000 0x400>;
> +			clocks = <&ccu CLK_BUS_GPADC0>, <&ccu CLK_GPADC0>;
> +			clock-names = "bus", "mod";
> +			resets = <&ccu RST_BUS_GPADC0>;
> +			interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> +			#io-channel-cells = <1>;

Should this node also include #address-cells = <1>; and #size-cells = <0>;?

The driver for this hardware requires channel@X child nodes to probe
successfully. Since these child nodes use reg properties to specify the
channel, omitting the cell properties from the base dtsi forces every board
file to redundantly declare them.

Including them here would prevent DTC warnings or probe failures if a board
author forgets to add them when enabling the device.

> +			status = "disabled";
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-sunxi-a523-gpadc-v2-0-d5efde151dac@mmpsystems.pl?part=3