From: sashiko-bot@kernel.org
To: "Kathiravan Thirumoorthy" <kathiravan.thirumoorthy@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH v10 3/3] arm64: dts: qcom: ipq5424: add support to get watchdog bootstatus from IMEM
Date: Thu, 14 May 2026 02:48:21 +0000 [thread overview]
Message-ID: <20260514024821.B185BC2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260513-wdt_reset_reason-v10-3-cebda08ab1ef@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Device Tree binding schema violation for the watchdog node.
- [Medium] Missing watchdog driver implementation and commit message mismatch.
--
commit 552b829d163556b75c4f936455d4ccee76a98307
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
arm64: dts: qcom: ipq5424: add support to get watchdog bootstatus from IMEM
This commit adds an "sram" property to the watchdog node in the IPQ5424
device tree and defines a new restart_reason node. The commit message
states this allows the watchdog driver to retrieve the system restart
reason from IMEM.
> Parse this information in the watchdog driver and update the bootstatus
> sysFS if the restart was triggered by a watchdog timeout.
The commit message mentions parsing this information in the watchdog
driver, but the patch only contains device tree changes. Should this
commit also include the modifications to the watchdog driver code, or
are those changes being introduced in a separate patch?
> diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> index 9b8410e326290..33ff00990513c 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> @@ -624,6 +624,7 @@ watchdog@f410000 {
> reg = <0 0x0f410000 0 0x1000>;
> interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
> clocks = <&sleep_clk>;
> + sram = <&restart_reason>;
> };
Will this new property cause device tree validation (make dtbs_check) to
fail?
It looks like the "sram" property might not be documented in the
corresponding device tree binding schema (qcom-wdt.yaml) yet. If the
schema enforces unevaluatedProperties as false, introducing an undocumented
property could trigger a validation error.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-wdt_reset_reason-v10-0-cebda08ab1ef@oss.qualcomm.com?part=3
prev parent reply other threads:[~2026-05-14 2:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 5:00 [PATCH v10 0/3] Add support to read the watchdog bootstatus from IMEM Kathiravan Thirumoorthy
2026-05-13 5:00 ` [PATCH v10 1/3] dt-bindings: sram: describe the IPQ5424 IMEM as mmio-sram Kathiravan Thirumoorthy
2026-05-13 5:00 ` [PATCH v10 2/3] arm64: dts: qcom: ipq5424: Add the IMEM node Kathiravan Thirumoorthy
2026-05-14 2:20 ` sashiko-bot
2026-05-13 5:00 ` [PATCH v10 3/3] arm64: dts: qcom: ipq5424: add support to get watchdog bootstatus from IMEM Kathiravan Thirumoorthy
2026-05-14 2:48 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514024821.B185BC2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox