From: sashiko-bot@kernel.org
To: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/2] dt-bindings: iio: light: add Broadcom APDS9999
Date: Thu, 14 May 2026 02:49:33 +0000 [thread overview]
Message-ID: <20260514024934.270E0C19425@smtp.kernel.org> (raw)
In-Reply-To: <438370a42f57250cbead53ac73834fbf9ccb9269.1778659152.git.azpijr@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect alphabetical placement of the new entry in the MAINTAINERS file.
--
commit 9c652efb6ad9a7c4e83bfb1ad645000b5ee9d6a4
Author: Jose A. Perez de Azpillaga <azpijr@gmail.com>
dt-bindings: iio: light: add Broadcom APDS9999
This commit adds Device Tree bindings for the Broadcom APDS9999 ambient light
and proximity sensor, and updates the MAINTAINERS file.
[ ... ]
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a92290fffa163..289130aeb4192 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3976,6 +3976,12 @@ S: Maintained
> F: Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml
> F: drivers/iio/light/apds9306.c
>
> +BROADCOM APDS9999 AMBIENT LIGHT SENSOR DRIVER
> +M: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> +L: linux-iio@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml
> +
> AVIA HX711 ANALOG DIGITAL CONVERTER IIO DRIVER
> M: Andreas Klinger <ak@it-klinger.de>
> L: linux-iio@vger.kernel.org
This isn't a bug, but should this new entry be placed further down in the
file to maintain alphabetical order?
It looks like the BROADCOM entry is currently inserted between the AVAGO and
AVIA entries, rather than in the B section.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1778659152.git.azpijr@gmail.com?part=1
prev parent reply other threads:[~2026-05-14 2:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1778659152.git.azpijr@gmail.com>
2026-05-13 8:10 ` [RFC PATCH v2 1/2] dt-bindings: iio: light: add Broadcom APDS9999 Jose A. Perez de Azpillaga
2026-05-14 2:49 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514024934.270E0C19425@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=azpijr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox