Re: [PATCH v5 01/10] dt-bindings: display: rockchip: analogix-dp: Fix hclk as third clock for RK3588

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree schema fails to correctly enforce the required number of clocks in the conditional blocks by omitting `minItems` and `maxItems` constraints.
--

commit 1eeef10904ab6c1e09008c1f85fab2353dd23f79
Author: Damon Ding <damon.ding@rock-chips.com>

dt-bindings: display: rockchip: analogix-dp: Fix hclk as third clock for RK3588

This commit enforces a third clock name on a per-compatible basis for
the analogix-dp driver. It removes the implicit clock enablement from
the GRF phandle and explicitly defines the clocks required for each SoC.

> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> index d99b23b88cc59..8001c1facf986 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml

[ ... ]

> @@ -60,6 +57,33 @@ required:
>  allOf:
>    - $ref: /schemas/display/bridge/analogix,dp.yaml#
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - rockchip,rk3288-dp
> +    then:
> +      properties:
> +        clock-names:
> +          items:
> +            - const: dp
> +            - const: pclk

Should this block include maxItems: 2? The top-level schema defines
maxItems: 3, which might allow a device tree with an extra unvalidated 
third clock string to silently pass validation here.

> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - rockchip,rk3399-edp
> +    then:
> +      properties:
> +        clock-names:
> +          items:
> +            - const: dp
> +            - const: pclk
> +            - const: grf

Does this block need minItems: 3 to ensure the grf clock is actually
enforced? Because the top-level schema allows minItems: 2, a device tree
omitting the third clock might still pass validation.

> +
>    - if:
>        properties:
>          compatible:
> @@ -68,6 +92,11 @@ allOf:
>                - rockchip,rk3588-edp
>      then:
>        properties:
> +        clock-names:
> +          items:
> +            - const: dp
> +            - const: pclk
> +            - const: hclk

Similarly, does this block also require minItems: 3? Without it, the 
hclk requirement might not be strictly enforced if the schema validation
falls back to the top-level minItems: 2 allowance.

>          resets:
>            minItems: 2
>          reset-names:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513074414.2053435-1-damon.ding@rock-chips.com?part=1