Re: [PATCH 1/3] dt-bindings: soc: imx: fsl,imx93-media-blk-ctrl: Allow LVDS Display Bridge child node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `bridge@20` child node is allowed unconditionally for all hardware variants in the binding, even though the i.MX91 hardware lacks an LVDS Display Bridge (LDB).
--

commit 1215972eab31b33c83565fc6226eed3ff41fba34
Author: Liu Ying <victor.liu@nxp.com>

dt-bindings: soc: imx: fsl,imx93-media-blk-ctrl: Allow LVDS Display Bridge child node

This commit allows the LVDS Display Bridge child node in the i.MX93 media
blk-ctrl binding and adds it to the example. The LDB_CTRL and LVDS registers
control video output through the LVDS interface.

> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
> index d828c2e82965c..ab563b457e07a 100644
> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml

[ ... ]

> @@ -92,6 +98,11 @@ properties:
>        - compatible
>        - ports
>  
> +  bridge@20:
> +    type: object
> +    $ref: /schemas/display/bridge/fsl,ldb.yaml#
> +    unevaluatedProperties: false
> +
>  allOf:
>    - if:
>        properties:

Since this binding is shared between fsl,imx91-media-blk-ctrl and
fsl,imx93-media-blk-ctrl, does adding bridge@20 to the top-level properties
unconditionally allow it for both variants?

If the i.MX91 hardware lacks the LVDS Display Bridge, should this child node
be explicitly disallowed by adding bridge@20: false to the allOf conditional
block for the i.MX91 compatible string?

Without this restriction, device trees incorrectly instantiating the LDB on
i.MX91 hardware might silently pass schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-imx93-ldb-v1-0-d11c5c3cc197@nxp.com?part=1