Re: [PATCH v1] arm64: dts: qcom: hamoa-iot-evk: add MCP2518FD CAN on spi18

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The fixed-clock node name 'can-clk' violates the devicetree schema and will cause a `dtbs_check` warning.
--

commit a4e072ba93299bc9cde800bbed0ba51dffbdac3a
Author: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>

arm64: dts: qcom: hamoa-iot-evk: add MCP2518FD CAN on spi18

This commit enables the Microchip MCP2518FD CAN-FD controller on hamoa.
The controller is connected via SPI18 and uses a 40 MHz oscillator.

> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> index 460f27dcd6f69..f260f23d2597a 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
[ ... ]
> @@ -29,6 +29,14 @@ backlight: backlight {
>  		pinctrl-names = "default";
>  	};
>  
> +	clocks {
> +		mcp2518fd_osc: can-clk {

This isn't a bug, but will the node name can-clk violate the devicetree
schema for fixed clocks?

According to the fixed-clock devicetree binding schema, the preferred node
name format is clock-<freq>. Any node name that does not match this pattern
generates a validation warning during make dtbs_check.

Could this be named clock-40000000 instead to prevent validation warnings?

> +			compatible = "fixed-clock";
> +			clock-frequency = <40000000>;
> +			#clock-cells = <0>;
> +		};
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-hamoa-spi-can-devicetree-v1-1-554a671a3789@oss.qualcomm.com?part=1