Re: [PATCH RESEND v7 1/3] dt-bindings: timer: mips,p8700-gcru

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The unit-address in the example node name does not match the first address in the 'reg' property.
--

commit 0fc6965163fbf81e3cf1b47f4dd36f18d5ee7201
Author: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>

dt-bindings: timer: mips,p8700-gcru

This commit adds dt-bindings for the GCR.U memory mapped timer device for
RISC-V platforms. The GCR.U memory region contains shadow copies of the
mtime and hrtime registers.

> diff --git a/Documentation/devicetree/bindings/timer/mips,p8700-gcru.yaml b/Documentation/devicetree/bindings/timer/mips,p8700-gcru.yaml
> new file mode 100644
> index 0000000000000..3498255762cce
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/mips,p8700-gcru.yaml

[ ... ]

> +examples:
> +  - |
> +    timer@1617f000 {

This isn't a bug, but does the unit-address in the node name need to match
the first address in the reg property?

> +        compatible = "mips,p8700-gcru";
> +        reg = <0x1617f050 0x8>,

The node is named timer@1617f000, but the first address specified in the
reg property is 0x1617f050. This mismatch might trigger a unit_address_vs_reg
warning when running make dt_binding_check.

> +              <0x1617f090 0x8>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-riscv-time-mmio-v7-0-f8925ffc226b@htecgroup.com?part=1