Re: [PATCH 1/2] dt-bindings: media: i2c: Add Sony IMX678

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing Generic Camera Properties
- [Medium] JSON Schema Anti-Pattern in `port` node
--

commit 3c708026acd2beae088666fedca4311601c91211
Author: Jai Luthra <jai.luthra@ideasonboard.com>

dt-bindings: media: i2c: Add Sony IMX678

This commit adds the device tree binding documentation for the Sony IMX678,
an 8.4 Megapixel CMOS sensor that outputs pixels over a MIPI CSI-2 bus. It
also updates the MAINTAINERS file for the new driver.

> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml
> new file mode 100644
> index 0000000000000..bb348b6e4f1b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml

[ ... ]

> +  reset-gpios:
> +    description: Sensor reset (XCLR) GPIO
> +    maxItems: 1
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false

Should this use unevaluatedProperties: false instead of
additionalProperties: false?

Under JSON Schema validation rules, additionalProperties: false only accounts
for keys explicitly listed in the local properties block and does not see
properties pulled in by the $ref.

This means any standard properties inherited from port-base (such as reg or
description) will be incorrectly rejected if specified in a device tree.

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - avdd-supply
> +  - ovdd-supply
> +  - dvdd-supply
> +  - port
> +
> +additionalProperties: false

Does this schema need to reference the generic video interface devices
schema?

Camera sensors frequently require physical mounting properties such as
orientation and rotation to describe their alignment to user-space.

Because of additionalProperties: false and the missing $ref to
/schemas/media/video-interface-devices.yaml#, any board device tree using
these standard properties will fail dt_binding_check validation.

Changing this to unevaluatedProperties: false and including the generic
video interface schema via an allOf block would allow those standard
properties to be used.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-imx678-v1-0-30fc593ed8fa@ideasonboard.com?part=1