From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E8CD37DEB1 for ; Thu, 14 May 2026 06:04:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738674; cv=none; b=AJSXzfP2mNa7QNhFLzbPBdK0KHAOBtdrbGEZoHkVXqQztivWKZrP8qFFTsMWpBsMaOB4qVywaVVeOYuJqx9e2gQJF01WFRV/M2Vy92zk5aHpiI2ZUFtMn5CmLV26aEHxzHG4SmFlXkbF0PI1xlJIsbZkQijtEsY1jyyg8GyUCDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738674; c=relaxed/simple; bh=Azi4tlEMBFtqvH2+J2pzcq0yarmfMiWLmWTBWnuQ1VQ=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=XhcjVeQlpc/sak0eFDiVHdZRszKtR7Ndo0Kbp0+c/VedzTLSFkhrVpfsF/ElBfI6RgRoehCZBvLxE2ulExNlcNuI1x3gBhuQrlFuJ2XGl/GKxpTUPX+ykq7gWsEIdUntorjQVufK9NQuS4Qj4t4GtQ5wNw1sGn1fSZXHz3PRpaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k61XJ5i4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k61XJ5i4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8C5CC2BCC6; Thu, 14 May 2026 06:04:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778738674; bh=Azi4tlEMBFtqvH2+J2pzcq0yarmfMiWLmWTBWnuQ1VQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=k61XJ5i4pJJTQ/jb9y5kOF/W53T3z/nxN/bmHTcs3C3U+q3vEaJHtG6PqbfDgki4N hnFy85cE/cQ92v69bKdIMf/7KBMvlCkHgQJZNEc94Pc4Mofvjan+R862XDS1Mxilnq 0EUrT+m+XBzdS050uStii+/MNkASzCmlMnhJv3yhHBSyP5WTOwX81MHyWoJF6baRqV 0+OA7sZv4Dg4vE06EzNlfL6KdjWwE8oOt1aj4okeBUFxHy7GkSy93hLY9HL0WHJD22 5QLPDeFOAFuCRoHs6Cw4n+D21A6Vw7ksrbQlVvBmk3hcxW45Jntk5a9BrV4gf0K4Cg y1VtB3wvZJ25A== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/2] dt-bindings: clock: qcom: add missing definition for the USB2 PHY reset Reply-To: sashiko-reviews@lists.linux.dev To: "Bartosz Golaszewski" Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, krzk+dt@kernel.org In-Reply-To: <20260513-nord-clk-usb2-phy-v1-1-8eafcb2d5129@oss.qualcomm.com> References: <20260513-nord-clk-usb2-phy-v1-1-8eafcb2d5129@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 14 May 2026 06:04:33 +0000 Message-Id: <20260514060433.D8C5CC2BCC6@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The newly added reset macro is incorrectly named `NE_GCC_QUSB3PHY_P= RIM_BCR` instead of `NE_GCC_QUSB2PHY_PRIM_BCR`, contradicting the commit me= ssage. -- commit 995687d91ac26d49f12e0c08bcd404ce73e33d6c Author: Bartosz Golaszewski dt-bindings: clock: qcom: add missing definition for the USB2 PHY reset This commit adds the missing USB2 PHY reset definition to the nord-negcc clock bindings header. This provides the definition needed to add the USB nodes in the device tree. > diff --git a/include/dt-bindings/clock/qcom,nord-negcc.h b/include/dt-bin= dings/clock/qcom,nord-negcc.h > index 95f333d8e1aa7..c2d048d9fc9e9 100644 > --- a/include/dt-bindings/clock/qcom,nord-negcc.h > +++ b/include/dt-bindings/clock/qcom,nord-negcc.h [ ... ] > @@ -120,5 +120,6 @@ > #define NE_GCC_USB3_PHY_SEC_BCR 10 > #define NE_GCC_USB3PHY_PHY_PRIM_BCR 11 > #define NE_GCC_USB3PHY_PHY_SEC_BCR 12 > +#define NE_GCC_QUSB3PHY_PRIM_BCR 13 The commit message indicates this patch adds the USB2 PHY reset definition, but the introduced macro is named NE_GCC_QUSB3PHY_PRIM_BCR. Is this a typo? Should the macro be named NE_GCC_QUSB2PHY_PRIM_BCR to refle= ct a USB2 PHY rather than a USB3 PHY before it becomes locked into the dt-bindings API? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260513-nord-clk-u= sb2-phy-v1-0-8eafcb2d5129@oss.qualcomm.com?part=3D1