Re: [PATCH v4 1/2] arm64: dts: qcom: sdm670-google: add common device tree include

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The newly added common device tree file uses the deprecated GPL-2.0 SPDX identifier, contradicting the commit message.
- [Low] The `framebuffer` node retains a unit address in its name without a `reg` property, which triggers a dtc warning.
--

commit 1f4f677fcfc2b6d8ad7bf836706a7501c4b2897b
Author: Richard Acayan <mailingradian@gmail.com>

arm64: dts: qcom: sdm670-google: add common device tree include

This commit extracts the common elements from the Pixel 3a device tree into
a shared include file to support the Pixel 3a XL. It also rewrites the
original device tree to specify only non-XL properties.

> diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi
> new file mode 100644
> index 0000000000000..0f57b915186b7
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi
> @@ -0,0 +1,712 @@
> +// SPDX-License-Identifier: GPL-2.0

The commit message mentions changing the SPDX license identifier from GPL-2.0
to GPL-2.0-only, but this new common include file still uses GPL-2.0. Was
this an oversight when creating the new file?

[ ... ]

> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		framebuffer: framebuffer@9c000000 {
> +			compatible = "simple-framebuffer";
> +			memory-region = <&fb_mem>;
> +			width = <1080>;

Since the reg property was replaced with a memory-region reference, should
the @9c000000 unit address be removed from the node name to prevent a dtc
warning about a node having a unit name but no reg property?

Additionally, are the #address-cells, #size-cells, and ranges properties in
the parent chosen node still necessary now that the child node no longer
uses a reg property?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513172549.1345-1-mailingradian@gmail.com?part=1