Re: [PATCH v2 2/4] iio: light: veml6030: fix channel type when pushing events

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Returning IRQ_HANDLED on I2C read failure in the interrupt handler causes an interrupt storm.
--

commit 198c71e09b48e4ebbfc54cfa1edf78cced994d05
Author: Javier Carrasco <javier.carrasco.cruz@gmail.com>

iio: light: veml6030: fix channel type when pushing events

The events are registered for IIO_LIGHT and not for IIO_INTENSITY.
Use the correct channel type.

> diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
> index 745cf3ad7092e..855f052b60c2c 100644
> --- a/drivers/iio/light/veml6030.c
> +++ b/drivers/iio/light/veml6030.c
> @@ -871,9 +871,11 @@ static irqreturn_t veml6030_event_handler(int irq, void *private)

This isn't a bug introduced by this commit, but looking at the beginning of
veml6030_event_handler():

	ret = regmap_read(data->regmap, VEML6030_REG_ALS_INT, &reg);
	if (ret) {
		dev_err(&data->client->dev,
				"can't read als interrupt register %d\n", ret);
		return IRQ_HANDLED;
	}

Could returning IRQ_HANDLED on I2C read failure cause an interrupt storm?

The VEML6030 device uses a level-triggered interrupt which is cleared by the
hardware only when the VEML6030_REG_ALS_INT register is successfully read.
If regmap_read() fails, the device continues to assert the interrupt line.

Because the line is still asserted and IRQ_HANDLED signals the interrupt was
serviced, the core IRQ subsystem unmasks the line, which fires immediately and
wakes the threaded handler again.

Would it be better to return IRQ_NONE instead, so the IRQ core's spurious
interrupt detector can track the unhandled threaded interrupt and eventually
disable the misbehaving line?

>  	else
>  		evtdir = IIO_EV_DIR_FALLING;
>  
> -	iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_INTENSITY,
> -					0, IIO_EV_TYPE_THRESH, evtdir),
> -					iio_get_time_ns(indio_dev));
> +	iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_LIGHT,
> +						       0,
> +						       IIO_EV_TYPE_THRESH,
> +						       evtdir),
> +			iio_get_time_ns(indio_dev));
>  
>  	return IRQ_HANDLED;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-veml6031x00-v2-0-4703ca661a1d@gmail.com?part=2