Re: [PATCH v6 1/2] dt-bindings: PCI: mediatek: Add support for EcoNet EN7528

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The conditional block for `econet,en7528-pcie` uses `reset: false` instead of `resets: false`, failing to correctly forbid the standard `resets` property.
--

commit 31e1455525e7bb47d92cbe65ee706b4484b25676
Author: Caleb James DeLisle <cjd@cjdns.fr>

dt-bindings: PCI: mediatek: Add support for EcoNet EN7528

This commit introduces the EcoNet EN7528 SoC compatible string to the
MediaTek PCIe controller binding and adds a conditional block to define
its specific property constraints.

> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
[ ... ]
> @@ -226,6 +227,31 @@ allOf:
>  
>          mediatek,pbus-csr: false
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: econet,en7528-pcie
> +    then:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +
> +        clock-names:
> +          maxItems: 1
> +
> +        reset: false

Should this be resets (plural) instead of reset?

The standard property for hardware reset lines is resets. Setting reset to
false will fail to override the global definition, which means the schema 
might inadvertently allow the resets property instead of strictly forbidding
it for this hardware variant.

> +
> +        reset-names: false
> +
> +        power-domains: false
> +
> +        mediatek,pbus-csr: false
> +
> +      required:
> +        - phys
> +        - phy-names
> +
>  unevaluatedProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513191652.3200607-1-cjd@cjdns.fr?part=1