From: Chen-Yu Tsai <wenst@chromium.org>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
Yingying Tang <yingying.tang@oss.qualcomm.com>
Subject: [PATCH] checkpatch: Don't emit warnings for USB & PCI device DT compatible prefixes
Date: Thu, 14 May 2026 18:51:50 +0800 [thread overview]
Message-ID: <20260514105151.2771474-1-wenst@chromium.org> (raw)
The USB and PCI device bindings define some compatible patterns based
on device IDs that use the comma to separate vendor and product IDs.
These patterns include:
- usb[0-9a-f]{1,4},[0-9a-f]{1,4}
- pci[0-9a-f]{2,4},[0-9a-f]{1,4}
- pciclass,[01][0-9a-f]{3}([0-9a-f]{2})?
These are not real vendor prefixes. Don't emit warnings for them.
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
This is a simplified version of what Brian Norris previously posted [1],
but more comprehensive and more perl-y than what Yingying Tang posted
[2], which only covered the second pattern.
Hopefully everyone likes this version.
This is based on next-20260508.
[1] https://lore.kernel.org/all/20190223022440.146915-1-briannorris@chromium.org/
[2] https://lore.kernel.org/all/20251210073812.1380803-1-yingying.tang@oss.qualcomm.com/
scripts/checkpatch.pl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3727156e4cca..ccedf152acfd 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3795,6 +3795,9 @@ sub process {
next if $compat !~ /^([a-zA-Z0-9\-]+)\,/;
my $vendor = $1;
+ next if $vendor eq "pciclass";
+ next if $vendor =~ /^pci[a-f0-9]{2,4}$/;
+ next if $vendor =~ /^usb(if)?[a-f0-9]{1,4}$/;
`grep -Eq "\\"\\^\Q$vendor\E,\\.\\*\\":" $vp_file`;
if ( $? >> 8 ) {
WARN("UNDOCUMENTED_DT_STRING",
--
2.54.0.563.g4f69b47b94-goog
next reply other threads:[~2026-05-14 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 10:51 Chen-Yu Tsai [this message]
2026-05-14 17:40 ` [PATCH] checkpatch: Don't emit warnings for USB & PCI device DT compatible prefixes Brian Norris
2026-05-14 18:10 ` Joe Perches
2026-05-15 3:24 ` Chen-Yu Tsai
2026-05-14 18:31 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514105151.2771474-1-wenst@chromium.org \
--to=wenst@chromium.org \
--cc=apw@canonical.com \
--cc=briannorris@chromium.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=robh@kernel.org \
--cc=yingying.tang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox