Re: [PATCH v2 14/16] arm64: dts: ti: k3-am62p-j722s-common-main: Make main_conf a syscon

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Adding the generic 'syscon' compatible without an SoC-specific identifier violates the syscon devicetree bindings.
--

commit d90ed1b8cacb6fc6ff7bf1ad93349b9fab13ace3
Author: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

arm64: dts: ti: k3-am62p-j722s-common-main: Make main_conf a syscon

This commit changes the main_conf block to include the "syscon" compatible 
string. This allows drivers for various devices to access specific registers 
they need within the CTRL_MMR block.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> index f130c7cb998d7..5e8eb9f2fe243 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> @@ -40,7 +40,7 @@ gic_its: msi-controller@1820000 {
>  	};
>  
>  	main_conf: bus@100000 {
> -		compatible = "simple-bus";
> +		compatible = "simple-bus", "syscon";

Does adding the generic "syscon" compatible without an SoC-specific identifier
violate the syscon devicetree bindings?

According to Documentation/devicetree/bindings/mfd/syscon.yaml, any node
including the "syscon" compatible must also define a hardware-specific
compatible string (e.g., "ti,am62p-system-controller" or "ti,am62p-main-conf")
before the generic "syscon" string.

Modifying the property to exactly compatible = "simple-bus", "syscon"; might
result in dtbs_check validation errors. Should a proper SoC-specific
compatible be introduced to satisfy the binding?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-beagley-ai-display-v2-0-9e9bcefde6bc@ideasonboard.com?part=14