From: sashiko-bot@kernel.org
To: "Swamil Jain" <s-jain1@ti.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: ti: k3-am62l: Enable HDMI & DSI display
Date: Thu, 14 May 2026 11:20:11 +0000 [thread overview]
Message-ID: <20260514112012.0B0D0C2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260513210942.692269-1-s-jain1@ti.com>
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] Missing pinmux configurations for the DSS DPI interface.
- [High] Hardware IRQ routing mismatch for the HDMI bridge.
- [Medium] DSI display nodes are left disabled on the EVM.
--
commit 83fc36958520450910c6fa0df0ef01548f3f6fd9
Author: Devarsh Thakkar <devarsht@ti.com>
arm64: dts: ti: k3-am62l: Enable HDMI & DSI display
This commit adds DSS, DPHY, and DSI nodes to the base SoC devicetree,
along with enabling DSS and an HDMI bridge in the board devicetree.
> arm64: dts: ti: k3-am62l: Enable HDMI & DSI display
>
> Enable DSS, DSI and HDMI related nodes and pinmuxes.
Are these descriptions accurate for the actual changes in the patch?
The dsi0 and dphy_tx0 nodes are added with status = "disabled" in the base
dtsi, but they are not overridden with status = "okay" in the board-level
dts file, leaving the DSI subsystem physically disabled on the board.
Also, it appears the patch does not add any pinctrl properties or pin
configurations for the DSS node. The DSS DPI interface relies on a parallel
bus that must be physically routed to the sii9022 external HDMI bridge to
function.
> diff --git a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
> index a1af4571a815d..7462921e21804 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
[ ... ]
> @@ -192,6 +204,36 @@ exp2: gpio@23 {
> bootph-all;
> };
>
> + sii9022: bridge-hdmi@3b {
> + compatible = "sil,sii9022";
> + reg = <0x3b>;
> + interrupt-parent = <&exp1>;
> + interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
Does this interrupt routing match the hardware configuration?
Checking the gpio-line-names array defined for exp1 in k3-am62l3-evm.dts
reveals that index 16 is an unconnected pin (""), while the actual HDMI
interrupt line ("HDMI_INTn") is explicitly mapped to index 20. This could
prevent the HDMI bridge from receiving hotplug detect and EDID events.
> + #sound-dai-cells = <0>;
> + sil,i2s-data-lanes = < 0 >;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260513210942.692269-1-s-jain1@ti.com?part=1
prev parent reply other threads:[~2026-05-14 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 21:09 [PATCH] arm64: dts: ti: k3-am62l: Enable HDMI & DSI display Swamil Jain
2026-05-14 11:20 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514112012.0B0D0C2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s-jain1@ti.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox