Re: [PATCH v7 5/8] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message fails to mention and explain the addition of `.halt_check = BRANCH_HALT_SKIP` to `gcc_venus0_core0_vcodec0_clk` and `gcc_venus0_core1_vcodec0_clk`.
--

commit 4d497cce125abb4eb5e06f88b3056c8f33e326e0
Author: Erikas Bitovtas <xerikasxx@gmail.com>

clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled

This commit adds the HW_CTRL_TRIGGER flag to VENUS_CORE0_GDSC and
VENUS_CORE1_GDSC to indicate their control can be passed to hardware,
based on downstream device tree properties.

> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 45193b3d714ba..243d31a32e924 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -3664,6 +3664,7 @@ static struct clk_branch gcc_venus0_vcodec0_clk = {
>  
>  static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
>  	.halt_reg = 0x4c02c,
> +	.halt_check = BRANCH_HALT_SKIP,

This isn't a bug, but the commit message explains the addition of the
HW_CTRL_TRIGGER flag to the GDSCs without mentioning the modifications to the
associated clock branches.

While skipping the halt check is the correct approach for branch clocks tied
to hardware-triggered GDSCs (as software polling would time out while the
hardware keeps the clock gated), could the commit message be updated to also
document this change to .halt_check?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-msm8939-venus-rfc-v7-0-33c6c6fb9285@gmail.com?part=5