Re: [PATCH 1/2] arm64: dts: s32g: add PIT support for s32g2 and s32g3

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The Device Tree nodes for the PIT timers are named using the specific IP block name (`pit@...`) instead of the standard generic name (`timer@...`).
--

commit 427ff80913e8247c6a4011dd8722ce9a6b67e322
Author: Khristine Andreea Barbulescu <khristineandreea.barbulescu@oss.nxp.com>

arm64: dts: s32g: add PIT support for s32g2 and s32g3

This commit adds Device Tree nodes for the Programmable Interrupt Timer
(PIT0 and PIT1) blocks on S32G2 and S32G3 SoCs.

> diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi
> --- a/arch/arm64/boot/dts/freescale/s32g2.dtsi
> +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi

[ ... ]

> @@ -417,6 +417,15 @@ edma0: dma-controller@40144000 {
>  			clock-names = "dmamux0", "dmamux1";
>  		};
>  
> +		pit0: pit@40188000 {

This isn't a bug, but according to the Devicetree Specification (Section
2.2.2 "Generic Names Recommendation"), node names should reflect the
generic function of the device rather than the specific IP block.

Could this node, as well as the pit1 node and the equivalent nodes in
s32g3.dtsi, be named timer@... instead of pit@... to follow standard
Device Tree conventions?

> +			compatible = "nxp,s32g2-pit";
> +			reg = <0x40188000 0x3000>;
> +			interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clks 61>;
> +			clock-names = "pit";
> +			status = "disabled";
> +		};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514070605.996462-1-khristineandreea.barbulescu@oss.nxp.com?part=1