From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69FBC34404E for ; Thu, 14 May 2026 17:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778780429; cv=none; b=ttCz1BvKK3HD7ypE1HKIpJgApDI7uVc/IC9Yt7z5EuyODo8qPw4yQhbTBmgjsxZM4fr7eTOAAARjqMCxJROiG0EZqnkWpL5KyI8XgvvUdAjLZa0mtkkNjbL5mKfzLE0EPjzl6YD8zyF3p3GhpxHEj9EjrZnc9Ab9v8yaMySprz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778780429; c=relaxed/simple; bh=c1ezc6FWuTR15R5uDPCzL/WyMmIYtLCdcnBnSRs8GlI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=H2lwaUB0MWI7BG25sOGr1HlewyB7fzsIjCRfxLCSmcelguQJ/zR5Vo11OBQByz4A0h7CG/UZdrcbipWV6VXU4darb1q8FJkQxYj4BEmlPiLnpIXsRNcA4c7nCqHR8ipaZo3T6OupZqUDLid5w+80RTupQDQ7GTBXuDkX5vKvOr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eegDZ2IV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eegDZ2IV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B50A4C2BCB3; Thu, 14 May 2026 17:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778780429; bh=c1ezc6FWuTR15R5uDPCzL/WyMmIYtLCdcnBnSRs8GlI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=eegDZ2IVLlYeIb4/VlvIlW5ClmHaXrhnIp8rn0HlMNAFHMcABbkXzrszAnIQZ61m9 QUzkJjZGL+HHqk6P68aPl3XuoZBfhT2ZGCpUln1zZU2ZjrGU9aSRP14ZmH2KgDWNgL gfFhlEOv3hYNmLmcVbUumQKi6Nm+CfTrWV7NXicd469tncD4mAuo8ue6kfAG+TaWy0 IhDYJvnWyLZuo7wVmDtI5JDbJbdL6DGuFgqhSIUhGtlc6fJCyTst0AoA1yVLNT8HXk BVEPr/uZJ3kpd7M9utkE2Ut66ehS5je5BK16RbmH4fONToiC6Wk6SiK9NDLKg+L/+I q99Zqll+FW41w== From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/3] clk: qcom: ipq5210: Use icc-clk for enabling NoC related clocks Reply-To: sashiko-reviews@lists.linux.dev To: "Varadarajan Narayanan" Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org, krzk+dt@kernel.org In-Reply-To: <20260514-icc-ipq5210-v1-2-b5070dfbe460@oss.qualcomm.com> References: <20260514-icc-ipq5210-v1-2-b5070dfbe460@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 14 May 2026 17:40:27 +0000 Message-Id: <20260514174028.B50A4C2BCB3@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Unconditional use of `icc_sync_state` causes a build failure when `= CONFIG_INTERCONNECT` is disabled. -- commit 37903a411799e24a2be5123849fd59d7fd96d50a Author: Varadarajan Narayanan clk: qcom: ipq5210: Use icc-clk for enabling NoC related clocks This commit uses the icc-clk framework to enable NoC related clocks, adding interconnect provider configurations. It introduces icc_hws mappings and sets the sync_state callback to icc_sync_state. > diff --git a/drivers/clk/qcom/gcc-ipq5210.c b/drivers/clk/qcom/gcc-ipq521= 0.c > index 3a786a21bdff5..1111da24b512b 100644 > --- a/drivers/clk/qcom/gcc-ipq5210.c > +++ b/drivers/clk/qcom/gcc-ipq5210.c [ ... ] > @@ -2642,6 +2657,7 @@ static struct platform_driver gcc_ipq5210_driver = =3D { > .driver =3D { > .name =3D "qcom,gcc-ipq5210", > .of_match_table =3D gcc_ipq5210_match_table, > + .sync_state =3D icc_sync_state, Will this cause a build failure when CONFIG_INTERCONNECT is disabled? Looking at include/linux/interconnect-provider.h, icc_sync_state is only declared when CONFIG_INTERCONNECT is enabled, and there appears to be no empty inline stub provided for the disabled case.=20 If this driver is compiled without the interconnect framework (for instance, during a COMPILE_TEST), does it result in an undeclared identifier error? > }, > }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260514-icc-ipq521= 0-v1-0-b5070dfbe460@oss.qualcomm.com?part=3D2