Re: [PATCH v4 5/6] regulator: mt6359: Add regulator supply names

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The supply name for 'vbbck' in 'mt6359p_regulators' was incorrectly set to 'LDO_VIO18' instead of 'VIO18'.
--

commit c863063b2f41de345a843312e3b866262b280224
Author: Chen-Yu Tsai <wenst@chromium.org>

regulator: mt6359: Add regulator supply names

The MT6359 regulator DT binding defines the supply names for the PMIC.
This commit adds support for them by introducing .supply_name field
settings for each regulator. The LDOs share supplies, while buck
regulators have their own supplies related to their names.

> diff --git a/drivers/regulator/mt6359-regulator.c b/drivers/regulator/mt6359-regulator.c
> index bcf9a476a34e1..46cafe93b24e4 100644
> --- a/drivers/regulator/mt6359-regulator.c
> +++ b/drivers/regulator/mt6359-regulator.c
[ ... ]
> @@ -871,11 +879,11 @@ static const struct mt6359_regulator_info mt6359p_regulators[] = {
>  		   MT6359P_RG_LDO_VM18_EN_ADDR, MT6359P_RG_LDO_VM18_EN_SHIFT,
>  		   MT6359P_DA_VM18_B_EN_ADDR, MT6359P_RG_VM18_VOSEL_ADDR,
>  		   MT6359_RG_VM18_VOSEL_MASK << MT6359_RG_VM18_VOSEL_SHIFT,
>  		   1920),
> -	MT6359_LDO("ldo_vbbck", VBBCK, vbbck_voltages,
> +	MT6359_LDO("ldo_vbbck", VBBCK, "LDO_VIO18", vbbck_voltages,

In mt6359p_regulators, the supply name for vbbck was introduced as "LDO_VIO18",
whereas in mt6359_regulators it is set to "VIO18".

Because the descriptor name for vio18 is "VIO18", the condition
strcmp(desc->supply_name, vio18_name) != 0 in mt6359_regulator_probe() will
evaluate to true for the MT6359P variant on every boot.

This discrepancy triggers the fallback execution path inside the probe loop,
performing an unnecessary devm_kzalloc() to allocate a new regulator_desc and
correct the supply name dynamically.

Should this also be "VIO18" to prevent the permanent, unintended memory
allocation on MT6359P platforms?

>  		   MT6359P_RG_LDO_VBBCK_EN_ADDR, MT6359P_RG_LDO_VBBCK_EN_SHIFT,
>  		   MT6359P_DA_VBBCK_B_EN_ADDR, MT6359P_RG_VBBCK_VOSEL_ADDR,
>  		   MT6359P_RG_VBBCK_VOSEL_MASK << MT6359P_RG_VBBCK_VOSEL_SHIFT,
>  		   480),

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514091520.2718987-1-wenst@chromium.org?part=5