Re: [PATCH 2/2] soc/tegra: pmc: Add Tegra238 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `tegra238_pmc_regs` struct omits the initialization of `aowake_*` register offsets, causing them to default to 0. This will lead to register collisions and hardware state corruption during wakeup configuration.
--

commit 07ddf2c146f9b5cbae8ba71ab87489c0358d7d6c
Author: Prathamesh Shete <pshete@nvidia.com>

soc/tegra: pmc: Add Tegra238 support

This commit adds support for the PMC on Tegra238. The Tegra238 PMC is
largely similar to earlier chips but not completely compatible.

> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 2ee6539d796a5..4724b98fb1b16 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
[ ... ]
> @@ -4595,6 +4595,156 @@ static const struct tegra_pmc_soc tegra234_pmc_soc = {
[ ... ]
> +static const struct tegra_pmc_regs tegra238_pmc_regs = {
> +	.scratch0 = 0x2000,
> +	.rst_status = 0x70,
> +	.rst_source_shift = 0x2,
> +	.rst_source_mask = 0xfc,
> +	.rst_level_shift = 0x0,
> +	.rst_level_mask = 0x3,
> +};

Does this omit the initialization of the aowake_* register offsets?

Since fields like aowake_mask_w, aowake_status_w, aowake_status_r, and
aowake_tier2_routing are missing from the structure definition, they
will default to 0.

Looking at tegra238_pmc_soc below, it uses tegra186_pmc_irq_set_wake()
and tegra186_pmc_irq_set_type() for its wake operations. These functions
calculate register addresses based on these offsets.

If the offsets default to 0, wouldn't the wake mask, status, and routing
operations collide with offset 0x0 (which maps to the control register)
and potentially corrupt the hardware PMC state during wakeup
configuration?

> +
> +static const char * const tegra238_reset_sources[] = {
[ ... ]
> +static const struct tegra_pmc_soc tegra238_pmc_soc = {
[ ... ]
> +	.regs = &tegra238_pmc_regs,
> +	.init = tegra186_pmc_init,
> +	.setup_irq_polarity = tegra186_pmc_setup_irq_polarity,
> +	.set_wake_filters = tegra186_pmc_set_wake_filters,
> +	.irq_set_wake = tegra186_pmc_irq_set_wake,
> +	.irq_set_type = tegra186_pmc_irq_set_type,
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514124856.108606-1-pshete@nvidia.com?part=2