Re: [PATCH 3/4] arm64: dts: ti: k3-am67a-beagley-ai: Add overlay for IMX219 on CSI0

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The camera reset GPIO pin is incorrectly configured as PIN_INPUT instead of PIN_OUTPUT.
--

commit 993d862219c5039d0e1b221804ac5c16ba10eb4d
Author: Jai Luthra <jai.luthra@ideasonboard.com>

arm64: dts: ti: k3-am67a-beagley-ai: Add overlay for IMX219 on CSI0

This commit adds a device tree overlay for the BeagleY AI board to enable
the IMX219 camera sensor. It configures the clocks, regulators, pinmuxing,
and CSI2 receiver endpoints for the camera connected to the CSI0 port.

> diff --git a/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai-csi0-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai-csi0-imx219.dtso
> new file mode 100644
> index 0000000000000..52698d1a0f08f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai-csi0-imx219.dtso

[ ... ]

> +&mcu_pmx0 {
> +	cam0_reset_pins_default: cam0-default-reset-pins {
> +		pinctrl-single,pins = <
> +			J722S_MCU_IOPAD(0x003c, PIN_INPUT, 7) /* (C1) MCU_MCAN1_TX.MCU_GPIO0_15 */

Is PIN_INPUT the intended configuration for this camera reset pin?

Since this pin is used as an output signal to drive the reset line for the
IMX219 sensor, should it be configured as PIN_OUTPUT? While the GPIO
subsystem will set the direction correctly, configuring it as an input
enables the input receiver which might be unnecessary for a unidirectional
output.

> +		>;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-beagley-cameras-v1-0-5c3500b5a436@ideasonboard.com?part=3