From: sashiko-bot@kernel.org
To: "Abel Vesa" <abel.vesa@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH v5 3/3] arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support
Date: Thu, 14 May 2026 20:18:13 +0000 [thread overview]
Message-ID: <20260514201813.9AFDAC2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260514-eliza-adsp-usb-v5-3-a21056ffd892@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The compatible string 'qcom,eliza-pmic-glink' is used in the device tree but is not documented in the YAML bindings.
--
commit b9c08b3ae54cc2b9b02f4c789a987a560f3a9531
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support
This commit enables USB and ADSP support for the Eliza MTP by describing the
USB Type-C port and eUSB2 repeater. It also enables the USB controller, PHYs,
and the ADSP remoteproc.
> diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> index 90f629800cb02..3e41c95edb28f 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
[ ... ]
> @@ -54,6 +57,44 @@ bi_tcxo_ao_div2: bi-tcxo-ao-div2-clk {
> };
> };
>
> + pmic-glink {
> + compatible = "qcom,eliza-pmic-glink",
> + "qcom,sm8550-pmic-glink",
> + "qcom,pmic-glink";
Is the "qcom,eliza-pmic-glink" compatible string documented in the YAML
bindings?
It appears to be missing from the
Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml schema.
Will this cause validation to fail when running dtbs_check?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-eliza-adsp-usb-v5-0-a21056ffd892@oss.qualcomm.com?part=3
prev parent reply other threads:[~2026-05-14 20:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 13:54 [PATCH v5 0/3] arm64: dts: qcom: eliza: Add ADSP and USB support Abel Vesa
2026-05-14 13:54 ` [PATCH v5 1/3] arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes Abel Vesa
2026-05-14 13:54 ` [PATCH v5 2/3] arm64: dts: qcom: Add Eliza-specific PM7550BA dtsi Abel Vesa
2026-05-14 19:58 ` sashiko-bot
2026-05-14 13:54 ` [PATCH v5 3/3] arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support Abel Vesa
2026-05-14 20:18 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514201813.9AFDAC2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox