Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Chipone ICNA 35xx OLED driver bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message fails to document the 'ayaneo,pocketds-panel-top' hardware variant which is explicitly added in the binding.
--

commit 36858773652523a7b2ea619de14533f16238e5f6
Author: Aaron Kling <webgeek1234@gmail.com>

dt-bindings: display: panel: Add Chipone ICNA 35xx OLED driver bindings

This commit adds device tree bindings for the Chipone ICNA35xx series of
MIPI-DSI OLED panel drivers.

> The Chipone ICNA35xx series of DDICs are high refresh, low power
> MIPI-DSI drivers for OLED panels. The icna3512 is used by the Ayn Odin 2
> Portal and the icna3520 is used by the Ayn Thor top panel and the Ayn
> Odin 3.

This isn't a bug, but the commit message appears to omit one of the panels
supported by the icna3512. The binding definition explicitly includes
ayaneo,pocketds-panel-top:

> diff --git a/Documentation/devicetree/bindings/display/panel/chipone,icna35xx.yaml b/Documentation/devicetree/bindings/display/panel/chipone,icna35xx.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/chipone,icna35xx.yaml
[ ... ]
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - ayaneo,pocketds-panel-top
> +              - ayntec,odin2portal-panel
> +          - const: chipone,icna3512

Should the commit message be updated to also mention the Ayaneo Pocket DS
top panel hardware variant alongside the Ayn Odin 2 Portal?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-icna35xx-v2-0-45acd1dfa566@gmail.com?part=1