Re: [PATCH v3 1/2] dt-bindings: display: panel: Add Chipone ICNA3512 OLED driver bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The schema incorrectly uses `additionalProperties: false` instead of `unevaluatedProperties: false` when referencing `panel-common.yaml`, and redundantly re-declares standard properties.
--

commit 147cb49a799b46e870bd7eeb02f8dcbaa4223d43
Author: Aaron Kling <webgeek1234@gmail.com>

dt-bindings: display: panel: Add Chipone ICNA3512 OLED driver bindings

The Chipone ICNA3512 and ICNA3520 DDICs are high refresh, low power
MIPI-DSI drivers for OLED panels. The icna3512 is used by the Ayn Odin 2
Portal and the Ayaneo Pocket DS top panel while the icna3520 is used by
the Ayn Thor top panel and the Ayn Odin 3. These ddic's are generally
compatible, but some MIPI vendor commands differ between them.

> diff --git a/Documentation/devicetree/bindings/display/panel/chipone,icna3512.yaml b/Documentation/devicetree/bindings/display/panel/chipone,icna3512.yaml
> new file mode 100644
> index 0000000000000..90e69f30cd91c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/chipone,icna3512.yaml
> @@ -0,0 +1,79 @@
[ ... ]
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
[ ... ]
> +  blvdd-supply: true
> +
> +  port: true
> +  reset-gpios: true
> +  rotation: true
> +
> +required:
[ ... ]
> +  - blvdd-supply
> +  - reset-gpios
> +
> +additionalProperties: false

This isn't a bug, but since this schema references panel-common.yaml under
allOf, should it use unevaluatedProperties: false instead of
additionalProperties: false?

Using additionalProperties: false forces the redundant declaration of
standard properties like port, reset-gpios, and rotation, and will reject
other standard panel properties.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-icna35xx-v3-0-c304f04c32c4@gmail.com?part=1