Re: [PATCH v2 13/17] arm64: dts: qcom: Add EL2 virtual timer interrupt

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to add the EL2 virtual timer interrupt, but for `sdx75.dtsi` and `milos.dtsi` it actually adds the EL2 physical timer interrupt (`GIC_PPI 10`).
--

commit 3f4b80b2c0c05477bcee12a9ba5b2e0a5b15a672
Author: Marc Zyngier <maz@kernel.org>

arm64: dts: qcom: Add EL2 virtual timer interrupt

This commit adds the missing EL2 virtual timer interrupt to the timer nodes
across multiple Qualcomm SoC device trees.

> arm64: dts: qcom: Add EL2 virtual timer interrupt
> 
> The ARMv8.1+ based CPUs used in a number of Qualcomm SoCs are missing
> the EL2 virtual timer interrupt. Add it.

Is this description entirely accurate?

The commit message explicitly states it adds the missing EL2 virtual timer
interrupt, but it appears to also add the EL2 physical timer interrupt in
a couple of files where the virtual timer was already present.

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
> index 4a64a98a434b6..b991124b8ce9f 100644
> --- a/arch/arm64/boot/dts/qcom/milos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi
> @@ -3235,6 +3235,7 @@ timer {
>  		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW 0>,
>  			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW 0>,
>  			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW 0>,
> +			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW 0>,
>  			     <GIC_PPI 12 IRQ_TYPE_LEVEL_LOW 0>;
>  	};
>  };

Does this inadvertently add the EL2 physical timer instead of the virtual
timer?

The virtual timer (GIC_PPI 12) is already present here, and this addition
is for GIC_PPI 10.

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> index d1b61530b562f..b6cdf71051026 100644
> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> @@ -1583,6 +1583,7 @@ timer {
>  		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
>  			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
>  			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
> +			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>,
>  			     <GIC_PPI 12 IRQ_TYPE_LEVEL_LOW>;
>  	};
>  };

Similarly, could the commit message be updated to mention this fix, or
should this physical timer addition be split into a separate patch?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514150945.3917510-1-maz@kernel.org?part=13