Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add NXP i.MX RT1180 NETC switch

[Krzysztof Kozlowski <krzk@kernel.org>]

On Sat, May 09, 2026 at 06:06:29PM +0900, Minghuan Lian wrote:
> +allOf:
> +  # Base: always a DSA switch

I have no clue what you want to say here.

> +  - $ref: /schemas/net/dsa/dsa.yaml#
> +
> +  # If the SPI-specific compatible is used, allow SPI properties and require reg.
> +  - if:
> +      properties:
> +        compatible:
> +          type: array

??? What? From where did you get such syntax?

> +          contains:
> +            const: nxp,imxrt1180-netc-switch-spi
> +    then:
> +      $ref: /schemas/spi/spi-peripheral-props.yaml#
> +      required:
> +        - reg
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      # SPI-attached switch representation (current integration)
> +      - items:
> +          - const: nxp,imxrt1180-netc-switch-spi
> +          - const: nxp,imxrt1180-netc-switch

Drop both. You have one compatible.

Please do not send us AI slop.

> +      # Transport-agnostic representation (future integration)

Drop comment. Get the binding reviewed internally in NXP.

> +      - const: nxp,imxrt1180-netc-switch
> +
> +  reg:
> +    description: |
> +      SPI chip select number (only for SPI-attached deployments).

Drop description.

> +    maxItems: 1
> +
> +required:
> +  - compatible

Best regards,
Krzysztof