Re: [PATCH v11 1/6] dt-bindings: iio: adc: add AD4691 family

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]

On Fri, May 15, 2026 at 01:37:52PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The binding defines GPIO controller capabilities but omits `gpio-controller` and `#gpio-cells` from the `required` list and the `examples` section.
> --
> 
> commit 5576d49868d1ae53d794381f2b3e2079954441db
> Author: Radu Sabau <radu.sabau@analog.com>
> 
> dt-bindings: iio: adc: add AD4691 family
> 
> This commit adds device tree bindings for the Analog Devices AD4691 family
> of multichannel SAR ADCs. It defines hardware connections including power
> domains, PWM, reset GPIOs, and interrupt sources, along with providing
> two binding examples.
> 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml
> > new file mode 100644
> > index 0000000000000..af28a0c1cfa9e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml
> 
> [ ... ]
> 
> > +  gpio-controller: true
> > +
> > +  '#gpio-cells':
> > +    const: 2
> > +
> > +  '#trigger-source-cells':
> > +    description:
> > +      This node can act as a trigger source. The single cell in a consumer
> > +      reference specifies the GP pin number (0-3) used as the trigger output.
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - avdd-supply
> > +  - vio-supply
> 
> Since the binding defines the device as a GPIO controller, should
> gpio-controller and #gpio-cells be added to this required list?
> 
> Omitting these properties from the required list might allow incomplete
> device tree nodes to pass validation.

This is crap right? The gpio pins are the same as the interrupt ones so
it has to be optional?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]