From: sashiko-bot@kernel.org
To: "Dario Binacchi" <dario.binacchi@amarulasolutions.com>
Cc: krzk+dt@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: simple: Add AM-1280800W8TZQW-T00H
Date: Fri, 15 May 2026 06:53:48 +0000 [thread overview]
Message-ID: <20260515065349.42769C2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260515064721.1750990-1-dario.binacchi@amarulasolutions.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The new compatible string is not inserted in alphabetical order.
- [Low] The panel description comment incorrectly states the resolution as WQVGA.
--
commit bf39295cb05fc88a5c9fc03f7444ba1eb3e26cfc
Author: Dario Binacchi <dario.binacchi@amarulasolutions.com>
dt-bindings: display: simple: Add AM-1280800W8TZQW-T00H
This commit adds dt-bindings for a 10.1" TFT LCD module from Ampire Co. Ltd.
to the panel-simple binding.
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 3e41ed0ef5d51..ea5fe23a6fe84 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -29,6 +29,8 @@ properties:
> # compatible must be listed in alphabetical order, ordered by compatible.
> # The description in the comment is mandatory for each compatible.
>
> + # Ampire AM-1280800W8TZQW-T00H 10.1" WQVGA TFT LCD panel
This isn't a bug, but is the WQVGA description accurate here? The part number
AM-1280800 suggests a 1280x800 resolution (WXGA), while WQVGA is typically
480x272. It looks like this might have been copied from another entry.
> + - ampire,am-1280800w8tzqw-t00h
> # Ampire AM-1280800N3TZQW-T00H 10.1" WQVGA TFT LCD panel
> - ampire,am-1280800n3tzqw-t00h
This isn't a bug, but should this new compatible be placed after
ampire,am-1280800n3tzqw-t00h? The comment above requires compatibles to be
listed in alphabetical order, and w comes after n.
> # Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515064721.1750990-1-dario.binacchi@amarulasolutions.com?part=1
prev parent reply other threads:[~2026-05-15 6:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 6:47 [PATCH 1/2] dt-bindings: display: simple: Add AM-1280800W8TZQW-T00H Dario Binacchi
2026-05-15 6:53 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515065349.42769C2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox