From: sashiko-bot@kernel.org
To: "Billy Tsai" <billy_tsai@aspeedtech.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
krzk+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: pinctrl: Add aspeed,ast2700-soc1-pinctrl
Date: Fri, 15 May 2026 10:08:05 +0000 [thread overview]
Message-ID: <20260515100812.9B81CC2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260515-pinctrl-single-bit-v3-2-e97da4312104@aspeedtech.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Schema uses `additionalProperties: false` alongside `$ref` instead of `unevaluatedProperties: false`.
--
commit f22ff0791aac86f631d0cc5f4662941db457d162
Author: Billy Tsai <billy_tsai@aspeedtech.com>
dt-bindings: pinctrl: Add aspeed,ast2700-soc1-pinctrl
This commit introduces a new devicetree binding schema for the ASPEED
AST2700 SoC1 pin controller. It reuses the standard pinmux and generic
pin configuration schemas.
> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2700-soc1-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2700-soc1-pinctrl.yaml
> new file mode 100644
> index 0000000000000..76944fd14e2c7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2700-soc1-pinctrl.yaml
> @@ -0,0 +1,760 @@
[ ... ]
> +patternProperties:
> + '-state$':
> + description: |
> + Pin control state.
[ ... ]
> + type: object
> + allOf:
> + - $ref: pinmux-node.yaml#
> + - $ref: pincfg-node.yaml#
[ ... ]
> + - pins
> + additionalProperties: false
Since this block references pinmux-node.yaml and pincfg-node.yaml, should
this use unevaluatedProperties: false instead? Using additionalProperties:
false might cause standard properties provided by the referenced schemas to
be incorrectly rejected during validation.
> +
> + properties:
> + function:
[ ... ]
> +required:
> + - compatible
> + - reg
> +
> +allOf:
> + - $ref: pinctrl.yaml#
> +
> +additionalProperties: false
Similarly, since the root level includes a reference to pinctrl.yaml, does
this also need to be unevaluatedProperties: false?
> +
> +examples:
> + - |
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-pinctrl-single-bit-v3-0-e97da4312104@aspeedtech.com?part=2
next prev parent reply other threads:[~2026-05-15 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 9:37 [PATCH v3 0/3] pinctrl: aspeed: Add AST2700 SoC1 support Billy Tsai
2026-05-15 9:37 ` [PATCH v3 1/3] dt-bindings: mfd: aspeed,ast2x00-scu: Support AST2700 SoC1 pinctrl Billy Tsai
2026-05-15 9:37 ` [PATCH v3 2/3] dt-bindings: pinctrl: Add aspeed,ast2700-soc1-pinctrl Billy Tsai
2026-05-15 10:08 ` sashiko-bot [this message]
2026-05-15 9:37 ` [PATCH v3 3/3] pinctrl: aspeed: Add AST2700 SoC1 support Billy Tsai
2026-05-15 10:40 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515100812.9B81CC2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=billy_tsai@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox